Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2552)

Unified Diff: base/trace_event/memory_dump_manager.cc

Issue 1069253003: [tracing] Fix single-process detection logic of ChildTraceMessageFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ipc_4_child
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/child/child_thread_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/memory_dump_manager.cc
diff --git a/base/trace_event/memory_dump_manager.cc b/base/trace_event/memory_dump_manager.cc
index ac79144f9fdb27d7830c1b26c977bd952b1e5824..ed965fa2b312a8ccc40a0fcd95be2acc485fa8ed 100644
--- a/base/trace_event/memory_dump_manager.cc
+++ b/base/trace_event/memory_dump_manager.cc
@@ -77,10 +77,7 @@ void MemoryDumpManager::Initialize() {
void MemoryDumpManager::SetDelegate(MemoryDumpManagerDelegate* delegate) {
AutoLock lock(lock_);
- // TODO(primiano): The DCHECK below is disabled just temporary (and it is
- // strongly useful). It should be re-enabled soon as crbug.com/474973 is fixed
- // (ETA: end of April 2015). Commenting out just to de-entangle CL deps.
- // DCHECK(delegate_ == nullptr);
+ DCHECK(delegate_ == nullptr);
Avi (use Gerrit) 2015/04/08 14:42:35 DCHECK_EQ(nullptr, delegate);
Primiano Tucci (use gerrit) 2015/04/08 15:04:29 Yeah, I was just too lazy to do the cast. Unfortun
Avi (use Gerrit) 2015/04/08 15:20:19 That's surprising; I've done it quite a bit. You c
delegate_ = delegate;
}
« no previous file with comments | « no previous file | content/child/child_thread_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698