Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1069213003: SVGLength: Avoid reading out-of-bounds when parsing incorrect 'rem' unit (Closed)

Created:
5 years, 8 months ago by fs
Modified:
5 years, 8 months ago
CC:
blink-reviews, krit, ed+blinkwatch_opera.com, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

SVGLength: Avoid reading out-of-bounds when parsing incorrect 'rem' unit The read/check of the third char ('m') could end up reading outside the buffer if unlucky. BUG=368598, 470449 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193523

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
A + LayoutTests/svg/custom/svg-length-rem-crash.html View 1 chunk +2 lines, -1 line 0 comments Download
A LayoutTests/svg/custom/svg-length-rem-crash-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGLength.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
fs
Stumbled upon by inspection, but will be triggered by ASAN with the "right" input.
5 years, 8 months ago (2015-04-09 12:58:45 UTC) #2
pdr.
LGTM @inferno, why didn't clusterfuzz catch this?
5 years, 8 months ago (2015-04-10 05:16:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069213003/1
5 years, 8 months ago (2015-04-10 07:55:49 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 08:00:35 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193523

Powered by Google App Engine
This is Rietveld 408576698