Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Issue 1069163002: Switch jsoncpp DEPS to github mirror (Closed)

Created:
5 years, 8 months ago by Sam Clegg
Modified:
5 years, 8 months ago
Reviewers:
iannucci, pthatcher2
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch jsoncpp DEPS to github mirror This change should be no-op. It simply changes the sha1 for jsoncpp to match the commit in the github repo rather than the git-svn mirror we previously used. The sha1 differs simply because the git-svn metadata was not used when they migrated to github. The tree contents are identical (the two commits have the same tree sha1). BUG=472809 Committed: https://crrev.com/12f9e9d69d223afd5c30dad8934932aefdeba35e Cr-Commit-Position: refs/heads/master@{#324477}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/jsoncpp/OWNERS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/jsoncpp/README.chromium View 1 2 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 24 (8 generated)
Sam Clegg
BTW, this makes the following mirrors unused: external/jsoncpp external/jsoncpp/jsoncpp external/jsoncpp/jsoncpp/include external/jsoncpp/jsoncpp/src/lib_json Is there some way ...
5 years, 8 months ago (2015-04-07 21:59:47 UTC) #2
Sam Clegg
ping.. (did you see this Robbie?)
5 years, 8 months ago (2015-04-08 21:33:16 UTC) #3
iannucci
lgtm
5 years, 8 months ago (2015-04-08 21:47:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069163002/20001
5 years, 8 months ago (2015-04-08 22:12:18 UTC) #6
Sam Clegg
+pthatcher for jsoncpp/OWNERS, sorry should have looped you in earlier.
5 years, 8 months ago (2015-04-09 00:28:22 UTC) #8
Sam Clegg
On 2015/04/09 00:28:22, Sam Clegg wrote: > +pthatcher for jsoncpp/OWNERS, sorry should have looped you ...
5 years, 8 months ago (2015-04-09 00:30:02 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/54958)
5 years, 8 months ago (2015-04-09 03:19:46 UTC) #11
pthatcher2
Honestly, I don't even know how I became an OWNER (or, as it appears, THE ...
5 years, 8 months ago (2015-04-09 05:41:51 UTC) #12
Sam Clegg
OK, we use this is the NaCl SDK, so I've added myself as an OWNER. ...
5 years, 8 months ago (2015-04-09 16:50:01 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069163002/40001
5 years, 8 months ago (2015-04-09 16:50:33 UTC) #16
pthatcher2
5 years, 8 months ago (2015-04-09 16:54:58 UTC) #17
pthatcher2
lgtm
5 years, 8 months ago (2015-04-09 16:55:04 UTC) #18
commit-bot: I haz the power
This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-09 18:16:22 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069163002/40001
5 years, 8 months ago (2015-04-09 18:18:14 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-09 18:20:21 UTC) #23
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 18:21:16 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/12f9e9d69d223afd5c30dad8934932aefdeba35e
Cr-Commit-Position: refs/heads/master@{#324477}

Powered by Google App Engine
This is Rietveld 408576698