Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 1069153002: Remove BisonCSSParser references in comments (Closed)

Created:
5 years, 8 months ago by rwlbuis
Modified:
5 years, 8 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, blink-reviews-style_chromium.org, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove BisonCSSParser references in comments Remove references to BisonCSSParser in comments to keep these valid once the new CSS parser is enabled. In fact some of the references are wrong since CSSPropertyParser should be referenced instead. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193329

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M Source/core/css/CSSPrimitiveValue.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StyleRuleKeyframe.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
rwlbuis
PTAL
5 years, 8 months ago (2015-04-07 21:41:29 UTC) #2
Timothy Loh
On 2015/04/07 21:41:29, rwlbuis wrote: > PTAL lgtm, but I prefer not using NOTRY=true on ...
5 years, 8 months ago (2015-04-07 23:59:40 UTC) #3
rwlbuis
On 2015/04/07 23:59:40, Timothy Loh wrote: > On 2015/04/07 21:41:29, rwlbuis wrote: > > PTAL ...
5 years, 8 months ago (2015-04-08 00:15:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069153002/1
5 years, 8 months ago (2015-04-08 00:16:25 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 06:18:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193329

Powered by Google App Engine
This is Rietveld 408576698