Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 1069083003: Revert of Add helper to validate JPEG decode subsampling factors (Closed)

Created:
5 years, 8 months ago by Noel Gordon
Modified:
5 years, 8 months ago
Reviewers:
pdr., sugoi1, reveman
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Add helper to validate JPEG decode subsampling factors (patchset #1 id:1 of https://codereview.chromium.org/1039503003/) Reason for revert: Per the bug, Factor 3 images are acceptable to libjpeg6b and users can even create them using its well-known cjpeg tool. Original issue's description: > Add helper to validate JPEG subsampling factors > > Use it to turn the invalid horizontal/vertical subsampling factor 3 to a > 1, which is fine for both the YUV decoding path (it won't turn on if any > of the component subsamplings is 3) and the normal JPEG decode path. > > TEST=Covered by the test added in r192900 > BUG=398235 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192980 TBR=sugoi@chromium.org,reveman@chromium.org,pdr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=398235 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193326

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp View 3 chunks +0 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Noel Gordon
Created Revert of Add helper to validate JPEG decode subsampling factors
5 years, 8 months ago (2015-04-08 05:12:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069083003/1
5 years, 8 months ago (2015-04-08 05:12:49 UTC) #2
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 05:13:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193326

Powered by Google App Engine
This is Rietveld 408576698