Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1069063002: Add ENABLE_MEDIA_ROUTER define (Closed)

Created:
5 years, 8 months ago by mark a. foltz
Modified:
5 years, 8 months ago
Reviewers:
Nico, imcheng
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ENABLE_MEDIA_ROUTER define to builds other than Android and iOS. BUG=461815 Committed: https://crrev.com/e62587c04a6a1732e61bff63fda0504d578fb391 Cr-Commit-Position: refs/heads/master@{#324177}

Patch Set 1 #

Patch Set 2 : Add configs to .gn #

Total comments: 2

Patch Set 3 : Revert BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M build/config/features.gni View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
mark a. foltz
5 years, 8 months ago (2015-04-07 20:07:10 UTC) #2
Nico
Do you need this in the .gn file too?
5 years, 8 months ago (2015-04-07 20:16:04 UTC) #3
Nico
Do you need this in the .gn file too?
5 years, 8 months ago (2015-04-07 20:16:04 UTC) #4
mark a. foltz
On 2015/04/07 20:16:04, Nico wrote: > Do you need this in the .gn file too? ...
5 years, 8 months ago (2015-04-07 20:29:13 UTC) #5
Nico
lgtm https://codereview.chromium.org/1069063002/diff/20001/build/config/BUILD.gn File build/config/BUILD.gn (right): https://codereview.chromium.org/1069063002/diff/20001/build/config/BUILD.gn#newcode39 build/config/BUILD.gn:39: # define, but anything that doesn't depend on ...
5 years, 8 months ago (2015-04-07 20:32:36 UTC) #6
mark a. foltz
https://codereview.chromium.org/1069063002/diff/20001/build/config/BUILD.gn File build/config/BUILD.gn (right): https://codereview.chromium.org/1069063002/diff/20001/build/config/BUILD.gn#newcode39 build/config/BUILD.gn:39: # define, but anything that doesn't depend on X11 ...
5 years, 8 months ago (2015-04-07 21:27:05 UTC) #7
imcheng
lgtm
5 years, 8 months ago (2015-04-07 23:42:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069063002/40001
5 years, 8 months ago (2015-04-07 23:59:07 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-08 02:32:30 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 02:33:21 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e62587c04a6a1732e61bff63fda0504d578fb391
Cr-Commit-Position: refs/heads/master@{#324177}

Powered by Google App Engine
This is Rietveld 408576698