tools/auto_bisect/bisect_perf_regression.py - Issue 1069033002: [bisect] - Bail early when bisecting return codes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/auto_bisect/bisect_perf_regression.py

Issue 1069033002: [bisect] - Bail early when bisecting return codes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/auto_bisect/bisect_perf_regression.py

diff --git a/tools/auto_bisect/bisect_perf_regression.py b/tools/auto_bisect/bisect_perf_regression.py

index ddc0f60cf82bd09149435488b36b2c501f6ff778..233a62d7723ce28a26037ef998586fe5a573da36 100755

--- a/tools/auto_bisect/bisect_perf_regression.py

+++ b/tools/auto_bisect/bisect_perf_regression.py

@@ -1364,6 +1364,9 @@ class BisectPerformanceMetrics(object):

break

elif self._IsBisectModeReturnCode():

metric_values.append(return_code)

+ # If there's a failed test, we can bail out early.

+ if return_code:

+ break

elapsed_minutes = (time.time() - start_time) / 60.0

time_limit = self.opts.max_time_minutes * test_run_multiplier

« no previous file with comments | « no previous file | no next file » | no next file with comments »