Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 106903017: Enable SPDY explicitly. (Closed)

Created:
7 years ago by sgurun-gerrit only
Modified:
6 years, 11 months ago
Reviewers:
Ryan Hamilton, boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Enable SPDY explicitly. BUG=332259 SPDY does not seem to be enabled by default. Enable it explicitly. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241889

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed code review.. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M android_webview/browser/net/aw_url_request_context_getter.cc View 1 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sgurun-gerrit only
@rch for review @boliu lgtm needed as owner of android_webview
7 years ago (2013-12-19 00:19:53 UTC) #1
boliu
https://codereview.chromium.org/106903017/diff/1/android_webview/browser/aw_browser_main_parts.cc File android_webview/browser/aw_browser_main_parts.cc (right): https://codereview.chromium.org/106903017/diff/1/android_webview/browser/aw_browser_main_parts.cc#newcode64 android_webview/browser/aw_browser_main_parts.cc:64: net::HttpStreamFactory::EnableNpnSpdy31(); Can this live somewhere in aw_url_request_context_getter.cc? That's where ...
7 years ago (2013-12-19 00:46:51 UTC) #2
sgurun-gerrit only
done. moved to AwUrlRequestContextGetter::InitializeURLRequestContext(). This is only called once, lazily when GetURLRequestContext() is called. https://codereview.chromium.org/106903017/diff/1/android_webview/browser/aw_browser_main_parts.cc ...
7 years ago (2013-12-19 01:54:14 UTC) #3
Ryan Hamilton
lgtm
7 years ago (2013-12-19 04:19:24 UTC) #4
boliu
lgtm
7 years ago (2013-12-19 04:20:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sgurun@chromium.org/106903017/20001
7 years ago (2013-12-19 16:02:33 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-19 18:28:08 UTC) #7
Message was sent while issue was closed.
Change committed as 241889

Powered by Google App Engine
This is Rietveld 408576698