Issue 106903009: Move page/RuntimeCSSEnabled to css/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 106903009: Move page/RuntimeCSSEnabled to css/ (Closed)

Created:
7 years ago by eseidel

Modified:
7 years ago

Reviewers:
abarth-chromium

CC:
blink-reviews, shans, apavlov+blink_chromium.org, adamk+blink_chromium.org, Steve Block, dino_apple.com, Nils Barth (inactive), Nate Chapin, arv+blink, alancutter (OOO until 2018), marja+watch_chromium.org, Timothy Loh, abarth-chromium, dstockwell, dglazkov+blink, Eric Willigers, rjwright, kinuko, darktears, haraken, kojih, jsbell+bindings_chromium.org, Mike Lawther (Google), Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Move page/RuntimeCSSEnabled to css/ It has no dependencies on page/ and it will remain in blink/core even when the rest of page goes up into the embedder. I originally moved this to frame/ but since it only really applies to the css directory (and a few directories which depend on css) I decided it made the most sense there. I tested building on linux. TBR=abarth@chromium.org BUG=305811 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163827

Patch Set 1 #

Total comments: 1

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -239 lines)			Patch
M	Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
	Source/core/animation/ElementAnimation.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/core.gypi	View	1 chunk	+2 lines, -2 lines	1 comment	Download
M	Source/core/css/CSSComputedStyleDeclaration.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/DOMWindowCSS.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	Source/core/css/RuntimeCSSEnabled.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	Source/core/css/RuntimeCSSEnabled.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/css/StylePropertySerializer.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/StylePropertySet.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/editing/EditingStyle.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
D	Source/core/page/RuntimeCSSEnabled.h	View	1 chunk	+0 lines, -56 lines	0 comments	Download
D	Source/core/page/RuntimeCSSEnabled.cpp	View	1 chunk	+0 lines, -172 lines	0 comments	Download
M	Source/modules/quota/DOMWindowQuota.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

7 years ago (2013-12-13 07:09:22 UTC) #2

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/106903009/diff/1/Source/core/core.gypi
File Source/core/core.gypi (right):

https://codereview.chromium.org/106903009/diff/1/Source/core/core.gypi#newcod...
Source/core/core.gypi:1319: 'css/RuntimeCSSEnabled.h',
Please sort the GYPI file.

Expand Messages | Collapse Messages