LayoutTests/fast/dom/custom/document-register-on-create-callback.html - Issue 106903007: Let unresolved custom element go through CustomElementCallbackQueue.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/custom/document-register-on-create-callback.html

Issue 106903007: Let unresolved custom element go through CustomElementCallbackQueue. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Updated. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/fast/dom/custom/created-callback.html ('K') | « LayoutTests/fast/dom/custom/created-callback-expected.txt ('k') | LayoutTests/fast/dom/custom/document-register-on-create-callback-expected.txt » ('j') | Source/core/dom/custom/CustomElementCallbackInvocation.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../resources/js-test.js"></script>
	dominicc (has gone to gerrit) 2013/12/18 08:46:41 Can we use the W3C test harness for this? Can we use the W3C test harness for this?
	3 <script>

	4 description("document.register() in a createdCallback should upgrade elements th at are in the same processing queue.");
	dominicc (has gone to gerrit) 2013/12/18 08:46:41 I think it is preferable to use single quotes for I think it is preferable to use single quotes for JavaScript string literals. That way markup-in-JavaScript strings, and JavaScript-in-attributes, can consistently use double quotes for attributes and single quotes for JavaScript strings. Hajime Morrita 2013/12/19 05:06:59 Done. Show quoted text On 2013/12/18 08:46:41, dominicc wrote: > I think it is preferable to use single quotes for JavaScript string literals. > That way markup-in-JavaScript strings, and JavaScript-in-attributes, can > consistently use double quotes for attributes and single quotes for JavaScript > strings. Done.
	5

	6 var createdElements = [];

	7

	8 var protoA = Object.create(HTMLElement.prototype);

	9 protoA.createdCallback = function () {

	10 createdElements.push(this.id);

	11 var protoB = Object.create(HTMLElement.prototype);

	12 protoB.createdCallback = function () {

	13 createdElements.push(this.id);

	14 };

	15

	16 document.register('x-b', {prototype: protoB});

	17 shouldBe("createdElements", "['elemA0', 'elemB0']");
	dominicc (has gone to gerrit) 2013/12/18 08:46:41 Same here, use ' for the outermost string literal. Same here, use ' for the outermost string literal. Hajime Morrita 2013/12/19 05:06:59 Done. Show quoted text On 2013/12/18 08:46:41, dominicc wrote: > Same here, use ' for the outermost string literal. Done.
	18 };

	19

	20 document.register('x-a', {prototype: protoA});

	21 </script>

	22 <x-b id=elemB0></x-b>
	dominicc (has gone to gerrit) 2013/12/18 08:46:41 Quote these attributes for consistency. Quote these attributes for consistency. Hajime Morrita 2013/12/19 05:06:59 Done. Show quoted text On 2013/12/18 08:46:41, dominicc wrote: > Quote these attributes for consistency. Done.
	23 <x-a id=elemA0></x-a>

	24 <x-b id=elemB1></x-b>

	25 <script>

	26 shouldBe("createdElements", "['elemA0', 'elemB0', 'elemB1']");
	dominicc (has gone to gerrit) 2013/12/18 08:46:41 And here. And here. Hajime Morrita 2013/12/19 05:06:59 Done. Show quoted text On 2013/12/18 08:46:41, dominicc wrote: > And here. Done.
	27 </script>

OLD	NEW