LayoutTests/fast/dom/custom/document-register-on-create-callback.html - Issue 106903007: Let unresolved custom element go through CustomElementCallbackQueue.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/custom/document-register-on-create-callback.html

Issue 106903007: Let unresolved custom element go through CustomElementCallbackQueue. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Updated Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | LayoutTests/fast/dom/custom/document-register-on-create-callback-expected.txt » ('j') | LayoutTests/fast/dom/custom/document-register-on-create-callback-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../resources/js-test.js"></script>
	dominicc (has gone to gerrit) 2013/12/14 02:42:39 I want to know more about your concern re: timing. I want to know more about your concern re: timing. The W3C test runner test(...) is fine for this, I think. I think the mechanics of this test look good now. Hajime Morrita 2013/12/16 09:00:34 It's tricky to interleave <script> elements and ot Show quoted text On 2013/12/14 02:42:39, dominicc wrote: > I want to know more about your concern re: timing. The W3C test runner test(...) > is fine for this, I think. It's tricky to interleave <script> elements and other markups in this type of test. We could possibly have two test()s but seems strange because one depends on another. Also, callbacks will happen in microstacks, where the code is scoped by test() and it will confuse the test runner. dominicc (has gone to gerrit) 2013/12/18 08:46:41 Can't you use async_test? Show quoted text On 2013/12/16 09:00:34, morrita1 wrote: > On 2013/12/14 02:42:39, dominicc wrote: > > I want to know more about your concern re: timing. The W3C test runner > test(...) > > is fine for this, I think. > > It's tricky to interleave <script> elements and other markups in this type of > test. > We could possibly have two test()s but seems strange because one depends on > another. > Also, callbacks will happen in microstacks, where the code is scoped by test() > and > it will confuse the test runner. Can't you use async_test?
	3 <script>

	4 description("document.register() in a createdCallback should upgrade elements th at are in the same processing queue.");

	5

	6 var createdElements = [];

	7

	8 var protoA = Object.create(HTMLElement.prototype);

	9 protoA.createdCallback = function () {

	10 createdElements.push(this.id);

	11 var protoB = Object.create(HTMLElement.prototype);

	12 protoB.createdCallback = function () {

	13 createdElements.push(this.id);

	14 };

	15

	16 document.register('x-b', {prototype: protoB});

	17 shouldBe("createdElements", "['elemA0', 'elemB0']");

	18 };

	19

	20 document.register('x-a', {prototype: protoA});

	21 </script>

	22 <x-b id=elemB0></x-b>

	23 <x-a id=elemA0></x-a>

	24 <x-b id=elemB1></x-b>

	25 <script>

	26 shouldBe("createdElements", "['elemA0', 'elemB0', 'elemB1']");

	27 </script>

OLD	NEW