LayoutTests/fast/dom/custom/document-register-on-create-callback.html - Issue 106903007: Let unresolved custom element go through CustomElementCallbackQueue.

Side by Side Diff: LayoutTests/fast/dom/custom/document-register-on-create-callback.html

Issue 106903007: Let unresolved custom element go through CustomElementCallbackQueue. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | LayoutTests/fast/dom/custom/document-register-on-create-callback-expected.txt » ('j') | LayoutTests/fast/dom/custom/document-register-on-create-callback-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../../../resources/js-test.js"></script>
	dominicc (has gone to gerrit) 2013/12/13 05:11:16 We could use the W3C test harness for this test an We could use the W3C test harness for this test and consider upstreaming it to W3C. Maybe copy fast/dom/custom/attribute-changed-callback.html for the style... I have been cutting down on elements the HTML parser will insert like <html>, <head>. Hajime Morrita 2013/12/13 07:02:29 In this case the execution order matters. So I'd r In this case the execution order matters. So I'd rather use this straightforward style.
	5 </head>

	6 <body>

	7 <script>

	8 description("document.register() should affect even for queued elements.");

	9

	10 var createdElements = [];

	11

	12 var protoA = Object.create(HTMLElement.prototype);

	13 protoA.createdCallback = function () {

	14 createdElements.push(this);

	15 var protoB = Object.create(HTMLElement.prototype);

	16 protoB.createdCallback = function () {

	17 createdElements.push(this);

	18 };

	19

	20 document.register('x-b', {prototype: protoB});

	21 };

	22

	23 document.register('x-a', {prototype: protoA});

	24 </script>

	25 <x-a id=elemA></x-a>

	26 <x-b id=elemB></x-b>

	27 <x-c id=elemC></x-c>
	dominicc (has gone to gerrit) 2013/12/13 05:11:16 I think this element is a distraction; if it isn't I think this element is a distraction; if it isn't needed let's remove it. Hajime Morrita 2013/12/13 07:02:29 Done. Show quoted text On 2013/12/13 05:11:16, dominicc wrote: > I think this element is a distraction; if it isn't needed let's remove it. Done.
	28 <script>

	29 shouldBe("createdElements.map(function(e) { return e.id; })", "['elemA', 'elemB' ]");
	dominicc (has gone to gerrit) 2013/12/13 05:11:16 It might be simpler to have the createdCallback si It might be simpler to have the createdCallback simply push the IDs into the array and just compare the value of createdElements to the expected value. Hajime Morrita 2013/12/13 07:02:29 Done. Show quoted text On 2013/12/13 05:11:16, dominicc wrote: > It might be simpler to have the createdCallback simply push the IDs into the > array and just compare the value of createdElements to the expected value. Done.
	30 </script>

	31 </body>

	32 </html>
	dominicc (has gone to gerrit) 2013/12/13 05:11:16 I think I understand what this is testing... it's I think I understand what this is testing... it's testing that if A and B are parsed as a group, but A's created callback registers B, that upgrade happens. Can the test make that clearer? Would it be different/more interesting/also interesting if B is parsed before A? Hajime Morrita 2013/12/13 07:02:29 Good point. I added another element to exercise th Show quoted text On 2013/12/13 05:11:16, dominicc wrote: > I think I understand what this is testing... it's testing that if A and B are > parsed as a group, but A's created callback registers B, that upgrade happens. > Can the test make that clearer? > > Would it be different/more interesting/also interesting if B is parsed before A? Good point. I added another element to exercise that.
OLD	NEW