add realloc method to SkAutoSTMalloc

add realloc method to SkAutoSTMalloc

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/f1f8895cbec1a9b7ec4eaa7c322aa03a4469612a

[joshualitt, 2015-04-07 18:26:23]

joshualitt@google.com changed reviewers:
+ joshualitt@google.com, mtklein@google.com

[mtklein, 2015-04-07 19:27:34]

https://codereview.chromium.org/1069013002/diff/20001/include/core/SkTemplates.h
File include/core/SkTemplates.h (right):

https://codereview.chromium.org/1069013002/diff/20001/include/core/SkTemplate...
include/core/SkTemplates.h:472: fPtr = (T*)sk_malloc_flags(count * sizeof(T),
SK_MALLOC_THROW | SK_MALLOC_TEMP);
Let's use sk_malloc_throw.  I don't believe SK_MALLOC_TEMP does anything, but if
it did this sure wouldn't be the place to use it.

https://codereview.chromium.org/1069013002/diff/20001/include/core/SkTemplate...
include/core/SkTemplates.h:478: memcpy(fTStorage, fPtr, N);
Do you ever really hit this case that you shrink back into the static storage? 
If not, let's not bother?

[joshualitt, 2015-04-07 19:38:25]

On 2015/04/07 19:27:34, mtklein wrote:
>
https://codereview.chromium.org/1069013002/diff/20001/include/core/SkTemplates.h
> File include/core/SkTemplates.h (right):
> 
>
https://codereview.chromium.org/1069013002/diff/20001/include/core/SkTemplate...
> include/core/SkTemplates.h:472: fPtr = (T*)sk_malloc_flags(count * sizeof(T),
> SK_MALLOC_THROW | SK_MALLOC_TEMP);
> Let's use sk_malloc_throw.  I don't believe SK_MALLOC_TEMP does anything, but
if
> it did this sure wouldn't be the place to use it.
> 
>
https://codereview.chromium.org/1069013002/diff/20001/include/core/SkTemplate...
> include/core/SkTemplates.h:478: memcpy(fTStorage, fPtr, N);
> Do you ever really hit this case that you shrink back into the static storage?

> If not, let's not bother?

Probably not, feedback incorporated

[mtklein, 2015-04-07 19:59:44]

https://codereview.chromium.org/1069013002/diff/40001/include/core/SkTemplates.h
File include/core/SkTemplates.h (right):

https://codereview.chromium.org/1069013002/diff/40001/include/core/SkTemplate...
include/core/SkTemplates.h:469: void realloc(size_t count) {
Don't we still need a count > N check for safety?

[joshualitt, 2015-04-07 21:14:12]

On 2015/04/07 19:59:44, mtklein wrote:
>
https://codereview.chromium.org/1069013002/diff/40001/include/core/SkTemplates.h
> File include/core/SkTemplates.h (right):
> 
>
https://codereview.chromium.org/1069013002/diff/40001/include/core/SkTemplate...
> include/core/SkTemplates.h:469: void realloc(size_t count) {
> Don't we still need a count > N check for safety?

Okay, I added some unit tests and fixed the bug.

[mtklein, 2015-04-08 13:20:05]

lgtm

https://codereview.chromium.org/1069013002/diff/80001/include/core/SkTemplates.h
File include/core/SkTemplates.h (right):

https://codereview.chromium.org/1069013002/diff/80001/include/core/SkTemplate...
include/core/SkTemplates.h:415: fPtr = NULL;
Does it seem weird that we treat count == 0 differently?

I'd think this'd just be fPtr = fTStorage, removing the else check in the other
constructor and reset and realloc.

[joshualitt, 2015-04-08 13:49:39]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-04-08 13:49:39]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1069013002/#ps100001
(title: "feedback inc")

[commit-bot: I haz the power, 2015-04-08 13:49:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1069013002/100001

[commit-bot: I haz the power, 2015-04-08 13:49:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-08 13:49:54]

Presubmit check for 1069013002-100001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of:
('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org',
'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')

[joshualitt, 2015-04-08 13:50:29]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com

[joshualitt, 2015-04-08 13:50:29]

Brian, can I get an l-g-t-m?

[bsalomon, 2015-04-08 14:00:54]

lgtm

[joshualitt, 2015-04-08 14:06:46]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2015-04-08 14:07:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1069013002/100001

[commit-bot: I haz the power, 2015-04-08 14:33:37]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/f1f8895cbec1a9b7ec4eaa7c322aa03a4469612a