Issue 10690048: Clean up RenderViewHostManager swapping logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10690048: Clean up RenderViewHostManager swapping logic. (Closed)

Created:
8 years, 5 months ago by Charlie Reis

Modified:
6 years, 9 months ago

Reviewers:

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Clean up RenderViewHostManager swapping logic. Makes the difference between swapping SiteInstances and swapping BrowsingInstances explicit, and adds CHECKs to enforce invariants more effectively. BUG=123007 TEST=No functionality change. [Closed: All changes have landed separately.]

Patch Set 1 #

Patch Set 2 : Merge and fix conflicts #

Patch Set 3 : Fix failing test. #

Patch Set 4 : Fix merge conflict #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+172 lines, -123 lines)			Patch
M	chrome/browser/chrome_content_browser_client.h	View	1 2	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/chrome_content_browser_client.cc	View	1 2 3	2 chunks	+33 lines, -18 lines	0 comments	Download
M	chrome/browser/extensions/api/management/management_api_browsertest.cc	View	1 2 3	2 chunks	+2 lines, -7 lines	0 comments	Download
M	content/browser/debugger/devtools_manager_unittest.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/web_contents/render_view_host_manager.h	View	1	2 chunks	+15 lines, -11 lines	0 comments	Download
M	content/browser/web_contents/render_view_host_manager.cc	View	1	9 chunks	+103 lines, -76 lines	0 comments	Download
M	content/browser/web_contents/render_view_host_manager_unittest.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/public/browser/content_browser_client.h	View	1 2 3	1 chunk	+7 lines, -4 lines	0 comments	Download
M	content/public/browser/content_browser_client.cc	View	1 2	1 chunk	+4 lines, -3 lines	0 comments	Download