Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1068973004: Web Animations: Support animation of SVG number attributes (Closed)

Created:
5 years, 8 months ago by Eric Willigers
Modified:
5 years, 8 months ago
CC:
dstockwell, darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Web Animations: Support animation of SVG number attributes Introduce NumberSVGInterpolation for animation of AnimatedNumber and AnimatedNumberList SVG properties. BUG=477529, 477531 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194082

Patch Set 1 #

Patch Set 2 : test negatives #

Patch Set 3 : rebase #

Total comments: 2

Patch Set 4 : moved logic to StringKeyframe #

Patch Set 5 : moveLogicToStringKeyframe #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+339 lines, -22 lines) Patch
M LayoutTests/animations/svg-attribute-interpolation/resources/interpolation-test.js View 1 2 3 4 5 4 chunks +13 lines, -1 line 0 comments Download
A LayoutTests/animations/svg-attribute-interpolation/svg-offset-interpolation.html View 1 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/animations/svg-attribute-interpolation/svg-offset-interpolation-expected.txt View 1 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/animations/svg-attribute-interpolation/svg-pathLength-interpolation.html View 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/animations/svg-attribute-interpolation/svg-pathLength-interpolation-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/animations/svg-attribute-interpolation/svg-tableValues-interpolation.html View 1 chunk +41 lines, -0 lines 0 comments Download
A LayoutTests/animations/svg-attribute-interpolation/svg-tableValues-interpolation-expected.txt View 1 chunk +25 lines, -0 lines 0 comments Download
A LayoutTests/animations/svg-attribute-interpolation/svg-values-interpolation.html View 1 1 chunk +30 lines, -0 lines 0 comments Download
A LayoutTests/animations/svg-attribute-interpolation/svg-values-interpolation-expected.txt View 1 1 chunk +15 lines, -0 lines 0 comments Download
A + LayoutTests/animations/svg-attribute-interpolation/svg-z-interpolation.html View 2 chunks +10 lines, -10 lines 0 comments Download
A LayoutTests/animations/svg-attribute-interpolation/svg-z-interpolation-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
M Source/core/animation/EffectInput.cpp View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/animation/IntegerOptionalIntegerSVGInterpolation.h View 1 2 3 4 5 2 chunks +7 lines, -3 lines 0 comments Download
M Source/core/animation/IntegerOptionalIntegerSVGInterpolation.cpp View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
A Source/core/animation/NumberSVGInterpolation.h View 1 2 3 1 chunk +63 lines, -0 lines 0 comments Download
A Source/core/animation/NumberSVGInterpolation.cpp View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download
M Source/core/animation/StringKeyframe.cpp View 1 2 3 4 5 2 chunks +12 lines, -2 lines 0 comments Download
M Source/core/core.gypi View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Eric Willigers
5 years, 8 months ago (2015-04-20 06:20:48 UTC) #2
Eric Willigers
5 years, 8 months ago (2015-04-20 06:26:04 UTC) #4
Eric Willigers
5 years, 8 months ago (2015-04-20 06:26:06 UTC) #5
alancutter (OOO until 2018)
lgtm https://codereview.chromium.org/1068973004/diff/40001/Source/core/animation/NumberSVGInterpolation.cpp File Source/core/animation/NumberSVGInterpolation.cpp (right): https://codereview.chromium.org/1068973004/diff/40001/Source/core/animation/NumberSVGInterpolation.cpp#newcode12 Source/core/animation/NumberSVGInterpolation.cpp:12: SVGNumberNegativeValuesMode negativeValuesMode = &attribute->attributeName() == &SVGNames::pathLengthAttr ? ForbidNegativeNumbers ...
5 years, 8 months ago (2015-04-20 07:39:40 UTC) #6
Eric Willigers
https://codereview.chromium.org/1068973004/diff/40001/Source/core/animation/NumberSVGInterpolation.cpp File Source/core/animation/NumberSVGInterpolation.cpp (right): https://codereview.chromium.org/1068973004/diff/40001/Source/core/animation/NumberSVGInterpolation.cpp#newcode12 Source/core/animation/NumberSVGInterpolation.cpp:12: SVGNumberNegativeValuesMode negativeValuesMode = &attribute->attributeName() == &SVGNames::pathLengthAttr ? ForbidNegativeNumbers : ...
5 years, 8 months ago (2015-04-21 00:51:16 UTC) #8
dstockwell
rs lgtm
5 years, 8 months ago (2015-04-21 01:57:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068973004/100001
5 years, 8 months ago (2015-04-21 03:00:31 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 04:10:28 UTC) #13
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194082

Powered by Google App Engine
This is Rietveld 408576698