|
|
DescriptionTry internal authentication URL if external fails.
BUG=chromium:356813
TEST=local
- Deleted cookies file, ran without patch, 404.
- Deleted cookies file, ran on internal network, works!
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294701
Patch Set 1 #
Total comments: 1
Patch Set 2 : Added internal error message strings. #Patch Set 3 : Better error mapping? #Patch Set 4 : Fixed exception naming bug. #Messages
Total messages: 22 (10 generated)
vadimsh@chromium.org changed reviewers: + vadimsh@chromium.org
https://codereview.chromium.org/1068973002/diff/1/third_party/upload.py File third_party/upload.py (right): https://codereview.chromium.org/1068973002/diff/1/third_party/upload.py#newco... third_party/upload.py:390: if e.reason == "BadAuthentication": this things may be different for ClientAuth. Try entering a wrong password to verify.
Added internal strings.
lgtm, thank you :)
The CQ bit was checked by dnj@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org Link to the patchset: https://codereview.chromium.org/1068973002/#ps60001 (title: "Fixed exception naming bug.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068973002/60001
The CQ bit was unchecked by dnj@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 1068973002-60001 failed and returned exit status 1. Running presubmit commit checks ... Checking out rietveld... Running save-description-on-failure.sh Running push-basic.sh Running upstream.sh Running submit-from-new-dir.sh Running abandon.sh Running submodule-merge-test.sh Running upload-local-tracking-branch.sh Running hooks.sh Running post-dcommit-hook-test.sh Running upload-stale.sh Running patch.sh Running basic.sh ** Presubmit ERRORS ** Missing LGTM from an OWNER for these files: depot_tools/third_party/upload.py Presubmit checks took 98.0s to calculate.
The CQ bit was checked by dnj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068973002/60001
dnj@chromium.org changed reviewers: + nodir@chromium.org, pgervais@chromium.org, stip@chromium.org
+ some owners
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 1068973002-60001 failed and returned exit status 1. Running presubmit commit checks ... Checking out rietveld... Running save-description-on-failure.sh Running push-basic.sh Running upstream.sh Running submit-from-new-dir.sh Running abandon.sh Running submodule-merge-test.sh Running upload-local-tracking-branch.sh Running hooks.sh Running post-dcommit-hook-test.sh Running upload-stale.sh Running patch.sh Running basic.sh ** Presubmit ERRORS ** Missing LGTM from an OWNER for these files: depot_tools/third_party/upload.py tests/gclient_smoketest.py (55.64s) failed Ffatal: reference is not a tree: 2b9fa1f5255048f6972b5166279fea62f7bd839d EE.............................................. ====================================================================== ERROR: testBlinkDEPSChangeUsingGit (__main__.BlinkDEPSTransitionSmokeTest) Like testBlinkDEPSChangeUsingGclient, but move the main project using ---------------------------------------------------------------------- Traceback (most recent call last): File "tests/gclient_smoketest.py", line 1630, in testBlinkDEPSChangeUsingGit cwd=self.checkout_path) File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line 484, in check_call check_call_out(args, **kwargs) File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line 478, in check_call_out returncode, args, kwargs.get('cwd'), out[0], out[1]) CalledProcessError: Command git checkout -q 2b9fa1f5255048f6972b5166279fea62f7bd839d returned non-zero exit status 128 in /tmp/trialyMoFoR/__main__.BlinkDEPSTransitionSmokeTest.testBlinkDEPSChangeUsingGit/src ====================================================================== ERROR: testBlinkLocalBranchesArePreserved (__main__.BlinkDEPSTransitionSmokeTest) Checks that the state of local git branches are effectively preserved ---------------------------------------------------------------------- Traceback (most recent call last): File "tests/gclient_smoketest.py", line 1656, in testBlinkLocalBranchesArePreserved self.CheckStatusPreMergePoint() File "tests/gclient_smoketest.py", line 1558, in CheckStatusPreMergePoint self.blink), self.blink_git_url) File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/scm.py", line 121, in Capture cwd=cwd, stderr=subprocess2.PIPE, env=env, **kwargs) File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line 515, in check_output return check_call_out(args, stdout=PIPE, **kwargs)[0] File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line 475, in check_call_out out, returncode = communicate(args, **kwargs) File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line 449, in communicate proc = Popen(args, **kwargs) File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line 253, in __init__ % (str(e), kwargs.get('cwd'), args[0])) OSError: Execution failed with error: [Errno 2] No such file or directory: '/tmp/trialyMoFoR/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit'. Check that /tmp/trialyMoFoR/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit or git exist and have execution permission. ====================================================================== FAIL: testBlinkDEPSChangeUsingGclient (__main__.BlinkDEPSTransitionSmokeTest) Checks that {src,blink} repos are consistent when syncing going back and ---------------------------------------------------------------------- Traceback (most recent call last): File "tests/gclient_smoketest.py", line 1601, in testBlinkDEPSChangeUsingGclient self.assertEqual(res[2], 0, 'DEPS change sync failed.') AssertionError: DEPS change sync failed. ---------------------------------------------------------------------- Ran 49 tests in 55.431s FAILED (failures=1, errors=2) Presubmit checks took 93.5s to calculate.
dnj@chromium.org changed reviewers: + agable@chromium.org, maruel@chromium.org
(Add the rest of the infra OWNERS) :)
lgtm
The CQ bit was checked by dnj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068973002/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=294701 |