Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1068973002: Try internal authentication URL if external fails. (Closed)

Created:
5 years, 8 months ago by dnj
Modified:
5 years, 8 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Try internal authentication URL if external fails. BUG=chromium:356813 TEST=local - Deleted cookies file, ran without patch, 404. - Deleted cookies file, ran on internal network, works! Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294701

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added internal error message strings. #

Patch Set 3 : Better error mapping? #

Patch Set 4 : Fixed exception naming bug. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M third_party/upload.py View 1 2 3 4 chunks +25 lines, -4 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
Vadim Sh.
https://codereview.chromium.org/1068973002/diff/1/third_party/upload.py File third_party/upload.py (right): https://codereview.chromium.org/1068973002/diff/1/third_party/upload.py#newcode390 third_party/upload.py:390: if e.reason == "BadAuthentication": this things may be different ...
5 years, 8 months ago (2015-04-07 17:31:10 UTC) #2
dnj
Added internal strings.
5 years, 8 months ago (2015-04-07 17:35:06 UTC) #3
Vadim Sh.
lgtm, thank you :)
5 years, 8 months ago (2015-04-07 17:36:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068973002/60001
5 years, 8 months ago (2015-04-07 17:41:16 UTC) #7
commit-bot: I haz the power
Presubmit check for 1068973002-60001 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 8 months ago (2015-04-07 17:43:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068973002/60001
5 years, 8 months ago (2015-04-07 17:44:51 UTC) #12
dnj
+ some owners
5 years, 8 months ago (2015-04-07 17:45:21 UTC) #14
commit-bot: I haz the power
Presubmit check for 1068973002-60001 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 8 months ago (2015-04-07 17:46:30 UTC) #16
dnj
(Add the rest of the infra OWNERS) :)
5 years, 8 months ago (2015-04-07 17:48:32 UTC) #18
ghost stip (do not use)
lgtm
5 years, 8 months ago (2015-04-07 17:56:41 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068973002/60001
5 years, 8 months ago (2015-04-07 17:57:13 UTC) #21
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 17:59:09 UTC) #22
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294701

Powered by Google App Engine
This is Rietveld 408576698