Implement separate error dialog for cws widget container

Implement separate error dialog for cws widget container

Make dialog modal to suggest apps dialog.
Fix issue where webview content would steal focus from dialog when user
hits tab.

BUG=439448
Committed: https://crrev.com/7ed1f876f6f4d79ac074b25f2066d514603aa18d
Cr-Commit-Position: refs/heads/master@{#325305}

[tbarzic, 2015-04-10 23:20:27]

tbarzic@chromium.org changed reviewers:
+ mtomasz@chromium.org, yoshiki@chromium.org

[tbarzic, 2015-04-10 23:20:28]

What do you think about doing something like this?

(depends on https://codereview.chromium.org/1061133005/)

[mtomasz, 2015-04-14 08:26:07]

lgtm with nits

https://codereview.chromium.org/1068883005/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/cws_widget_container.js (right):

https://codereview.chromium.org/1068883005/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/cws_widget_container.js:59:
parentNode.classList.add('cws-widget-container-root');
nit: It looks off here, can we move it to #69?

https://codereview.chromium.org/1068883005/diff/40001/ui/file_manager/file_ma...
File
ui/file_manager/file_manager/foreground/js/ui/cws_widget_container_error_dialog.js
(right):

https://codereview.chromium.org/1068883005/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/cws_widget_container_error_dialog.js:42:
// Don'a allow OK button to lose focus, in order to prevent webview content
typo: Don't

https://codereview.chromium.org/1068883005/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/cws_widget_container_error_dialog.js:44:
this.okButton_.addEventListener('blur', this.refocusOkButton_.bind(this));
Please add a comment why we need it. Normally tabIndex="-1" should resolve the
issue, but it seems it doesn't work right?

[tbarzic, 2015-04-15 03:52:52]

https://codereview.chromium.org/1068883005/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/cws_widget_container.js (right):

https://codereview.chromium.org/1068883005/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/cws_widget_container.js:59:
parentNode.classList.add('cws-widget-container-root');
On 2015/04/14 08:26:07, mtomasz wrote:
> nit: It looks off here, can we move it to #69?

Done.

https://codereview.chromium.org/1068883005/diff/40001/ui/file_manager/file_ma...
File
ui/file_manager/file_manager/foreground/js/ui/cws_widget_container_error_dialog.js
(right):

https://codereview.chromium.org/1068883005/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/cws_widget_container_error_dialog.js:42:
// Don'a allow OK button to lose focus, in order to prevent webview content
On 2015/04/14 08:26:07, mtomasz wrote:
> typo: Don't

Done.

https://codereview.chromium.org/1068883005/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/cws_widget_container_error_dialog.js:44:
this.okButton_.addEventListener('blur', this.refocusOkButton_.bind(this));
On 2015/04/14 08:26:07, mtomasz wrote:
> Please add a comment why we need it. Normally tabIndex="-1" should resolve the
> issue, but it seems it doesn't work right? 

Done.

[tbarzic, 2015-04-15 20:42:56]

The CQ bit was checked by tbarzic@chromium.org

[tbarzic, 2015-04-15 20:42:56]

The patchset sent to the CQ was uploaded after l-g-t-m from mtomasz@chromium.org
Link to the patchset: https://codereview.chromium.org/1068883005/#ps80001
(title: "rebase to ToT")

[commit-bot: I haz the power, 2015-04-15 20:44:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1068883005/80001

[commit-bot: I haz the power, 2015-04-15 21:11:24]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-04-15 21:14:20]

Patchset 5 (id:??) landed as
https://crrev.com/7ed1f876f6f4d79ac074b25f2066d514603aa18d
Cr-Commit-Position: refs/heads/master@{#325305}