Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1068883004: restore clipstack to heap-ptr, so clients can ref it (Closed)

Created:
5 years, 8 months ago by reed1
Modified:
5 years, 8 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

restore clipstack to heap-ptr, so clients can ref it BUG=skia: Committed: https://skia.googlesource.com/skia/+/687fa1c745febb57f42b0d5f03d7c1f4be2530ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -16 lines) Patch
M include/core/SkCanvas.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkCanvas.cpp View 14 chunks +16 lines, -14 lines 0 comments Download
M tests/CanvasTest.cpp View 3 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
reed1
ptal
5 years, 8 months ago (2015-04-07 14:41:55 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068883004/1
5 years, 8 months ago (2015-04-07 14:42:16 UTC) #4
joshualitt
On 2015/04/07 14:42:16, I haz the power (commit-bot) wrote: > Dry run: CQ is trying ...
5 years, 8 months ago (2015-04-07 14:44:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068883004/1
5 years, 8 months ago (2015-04-07 14:54:25 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 15:00:59 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/687fa1c745febb57f42b0d5f03d7c1f4be2530ca

Powered by Google App Engine
This is Rietveld 408576698