Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1068863003: [BackgroundSyncManager] Rename BackgroundSyncRegistration.name to tag (Closed)

Created:
5 years, 8 months ago by jkarlin
Modified:
5 years, 8 months ago
Reviewers:
johnme
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, jam, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, jkarlin+watch_chromium.org, darin-cc_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@registration_options
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[BackgroundSyncManager] Rename BackgroundSyncRegistration.name to tag This refactoring of 'name' to 'tag' is part of tracking the latest spec changes found in https://github.com/slightlyoff/BackgroundSync/pull/74 BUG=474573 Committed: https://crrev.com/1c8dbbf5c65c12c83c3dccbb34e888867a4572e3 Cr-Commit-Position: refs/heads/master@{#324233}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -83 lines) Patch
M content/browser/background_sync/background_sync.proto View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/background_sync/background_sync_manager.h View 1 2 10 chunks +13 lines, -13 lines 0 comments Download
M content/browser/background_sync/background_sync_manager.cc View 1 2 15 chunks +25 lines, -26 lines 0 comments Download
M content/browser/background_sync/background_sync_manager_unittest.cc View 20 chunks +43 lines, -43 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jkarlin
johnme: PTAL, thanks so much!
5 years, 8 months ago (2015-04-07 18:50:55 UTC) #2
johnme
lgtm
5 years, 8 months ago (2015-04-08 15:06:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068863003/60001
5 years, 8 months ago (2015-04-08 15:08:55 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 8 months ago (2015-04-08 16:54:12 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 16:55:22 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/1c8dbbf5c65c12c83c3dccbb34e888867a4572e3
Cr-Commit-Position: refs/heads/master@{#324233}

Powered by Google App Engine
This is Rietveld 408576698