Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: PRESUBMIT.py

Issue 1068853002: Bypass owners check for dry run CLs (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: Remove test code Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index a036be6fc84876ed218d9a52441511a40a1c2bd1..60439d6eb020641172b427c840bd3518211174c2 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -283,8 +283,11 @@ def _CheckLGTMsForPublicAPI(input_api, output_api):
# It is a revert CL, ignore the public api owners check.
return results
- if re.search(r'^COMMIT=false$', issue_properties['description'], re.M):
- # Ignore public api owners check for COMMIT=false CLs since they are not
+ # TODO(rmistry): Stop checking for COMMIT=false once crbug/470609 is
+ # resolved.
+ if issue_properties['cq_dry_run'] or re.search(
+ r'^COMMIT=false$', issue_properties['description'], re.M):
+ # Ignore public api owners check for dry run CLs since they are not
# going to be committed.
return results
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698