Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1068823003: Pass security origin to AesDecryptor() (Closed)

Created:
5 years, 8 months ago by jrummell
Modified:
5 years, 8 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, ben+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, mcasas+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, eme-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), wjia+watch_chromium.org, Aaron Boodman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass security origin to AesDecryptor() BUG=353324 TEST=existing EME tests pass Committed: https://crrev.com/647f1bac3175dcf1bbb71f64f6c5f3b0b1a3b1b3 Cr-Commit-Position: refs/heads/master@{#324314}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add GN dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -17 lines) Patch
M content/renderer/media/crypto/render_cdm_factory.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M media/cdm/aes_decryptor.h View 2 chunks +4 lines, -1 line 0 comments Download
M media/cdm/aes_decryptor.cc View 1 chunk +4 lines, -1 line 0 comments Download
M media/cdm/aes_decryptor_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/cdm/default_cdm_factory.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M media/cdm/ppapi/external_clear_key/clear_key_cdm.h View 2 chunks +3 lines, -1 line 0 comments Download
M media/cdm/ppapi/external_clear_key/clear_key_cdm.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_cdm_service.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M media/test/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M media/test/pipeline_integration_test.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
jrummell
PTAL.
5 years, 8 months ago (2015-04-07 17:47:42 UTC) #2
sandersd (OOO until July 31)
lgtm https://codereview.chromium.org/1068823003/diff/1/content/renderer/media/crypto/render_cdm_factory.cc File content/renderer/media/crypto/render_cdm_factory.cc (right): https://codereview.chromium.org/1068823003/diff/1/content/renderer/media/crypto/render_cdm_factory.cc#newcode52 content/renderer/media/crypto/render_cdm_factory.cc:52: if (!security_origin.is_valid()) What are we trying to check ...
5 years, 8 months ago (2015-04-07 19:37:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068823003/1
5 years, 8 months ago (2015-04-07 22:25:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/59607)
5 years, 8 months ago (2015-04-07 23:20:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068823003/20001
5 years, 8 months ago (2015-04-08 20:48:52 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-09 00:16:26 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 00:17:14 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/647f1bac3175dcf1bbb71f64f6c5f3b0b1a3b1b3
Cr-Commit-Position: refs/heads/master@{#324314}

Powered by Google App Engine
This is Rietveld 408576698