Add MacOS X 10.10 Yosemite support to GPUTestBotConfig.

Add MacOS X 10.10 Yosemite support to GPUTestBotConfig.

It allows test GPUTestConfigTest.LoadCurrentConfig to pass on Yosemite.

BUG=474551
TEST=gpu_unittests --gtest_filter="GPUTestConfigTest.LoadCurrentConfig"

Committed: https://crrev.com/3197ce8d01839ba9bb19a4b653c99b4f87eb64b5
Cr-Commit-Position: refs/heads/master@{#325221}

[Andrey Kraynov, 2015-04-07 12:10:55]

iceman@yandex-team.ru changed reviewers:
+ zmo@chromium.org

[Andrey Kraynov, 2015-04-07 12:10:55]

Hi!

Here I'm trying to fix GPUTestConfigTest.LoadCurrentConfig test on Yosemite.
Could you take a look at this CL, please?

Also, I see that these enum values are used in gpu_test_expectations_parser.cc.
Should I add new value to the |kTokenData| array?

[Andrey Kraynov, 2015-04-09 10:35:19]

iceman@yandex-team.ru changed reviewers:
+ kbr@chromium.org

[Andrey Kraynov, 2015-04-09 10:35:19]

Hi, Ken!

Could you PTAL?
Thanks in advance!

[Ken Russell (switch to Gerrit), 2015-04-10 00:43:09]

Thanks. LGTM

[Ken Russell (switch to Gerrit), 2015-04-10 00:47:02]

By the way -- we should improve the coverage of
src/gpu/config/gpu_test_config_unittest.cc. If you have ideas for refactoring
this class to improve testability please submit patches. Thanks.

[Andrey Kraynov, 2015-04-10 09:06:22]

On 2015/04/10 00:47:02, Ken Russell wrote:
> By the way -- we should improve the coverage of
> src/gpu/config/gpu_test_config_unittest.cc. If you have ideas for refactoring
> this class to improve testability please submit patches. Thanks.

OK, I'll have a look on it.
Could you give me an advice about the code in gpu_test_expectations_parser.cc?
Should I add new element to the |kTokenData| array?

[Ken Russell (switch to Gerrit), 2015-04-10 22:23:57]

On 2015/04/10 09:06:22, Andrey Kraynov wrote:
> On 2015/04/10 00:47:02, Ken Russell wrote:
> > By the way -- we should improve the coverage of
> > src/gpu/config/gpu_test_config_unittest.cc. If you have ideas for
refactoring
> > this class to improve testability please submit patches. Thanks.
> 
> OK, I'll have a look on it.
> Could you give me an advice about the code in gpu_test_expectations_parser.cc?
> Should I add new element to the |kTokenData| array?

Yes -- to the Token enum, kTokenData array, handle it in ParseConfig, etc. It
would be great if you'd modify this CL with these changes so that it's
self-contained.

[Andrey Kraynov, 2015-04-13 17:37:12]

On 2015/04/10 22:23:57, Ken Russell wrote:
> On 2015/04/10 09:06:22, Andrey Kraynov wrote:
> > On 2015/04/10 00:47:02, Ken Russell wrote:
> > > By the way -- we should improve the coverage of
> > > src/gpu/config/gpu_test_config_unittest.cc. If you have ideas for
> refactoring
> > > this class to improve testability please submit patches. Thanks.
> > 
> > OK, I'll have a look on it.
> > Could you give me an advice about the code in
gpu_test_expectations_parser.cc?
> > Should I add new element to the |kTokenData| array?
> 
> Yes -- to the Token enum, kTokenData array, handle it in ParseConfig, etc. It
> would be great if you'd modify this CL with these changes so that it's
> self-contained.

I've added kOsMacYosemite flag to gpu_test_expectations_parser.cc file.
Could you check this CL again?
Thanks!

[Ken Russell (switch to Gerrit), 2015-04-13 17:48:34]

On 2015/04/13 17:37:12, Andrey Kraynov wrote:
> On 2015/04/10 22:23:57, Ken Russell wrote:
> > On 2015/04/10 09:06:22, Andrey Kraynov wrote:
> > > On 2015/04/10 00:47:02, Ken Russell wrote:
> > > > By the way -- we should improve the coverage of
> > > > src/gpu/config/gpu_test_config_unittest.cc. If you have ideas for
> > refactoring
> > > > this class to improve testability please submit patches. Thanks.
> > > 
> > > OK, I'll have a look on it.
> > > Could you give me an advice about the code in
> gpu_test_expectations_parser.cc?
> > > Should I add new element to the |kTokenData| array?
> > 
> > Yes -- to the Token enum, kTokenData array, handle it in ParseConfig, etc.
It
> > would be great if you'd modify this CL with these changes so that it's
> > self-contained.
> 
> I've added kOsMacYosemite flag to gpu_test_expectations_parser.cc file.
> Could you check this CL again?
> Thanks!

How about adding some Mac tests to gpu_test_expectations_parser_unittest.cc, in
particular a test making sure the "yosemite" flag is working?

[Andrey Kraynov, 2015-04-13 20:56:32]

On 2015/04/13 17:48:34, Ken Russell wrote:
> On 2015/04/13 17:37:12, Andrey Kraynov wrote:
> > On 2015/04/10 22:23:57, Ken Russell wrote:
> > > On 2015/04/10 09:06:22, Andrey Kraynov wrote:
> > > > On 2015/04/10 00:47:02, Ken Russell wrote:
> > > > > By the way -- we should improve the coverage of
> > > > > src/gpu/config/gpu_test_config_unittest.cc. If you have ideas for
> > > refactoring
> > > > > this class to improve testability please submit patches. Thanks.
> > > > 
> > > > OK, I'll have a look on it.
> > > > Could you give me an advice about the code in
> > gpu_test_expectations_parser.cc?
> > > > Should I add new element to the |kTokenData| array?
> > > 
> > > Yes -- to the Token enum, kTokenData array, handle it in ParseConfig, etc.
> It
> > > would be great if you'd modify this CL with these changes so that it's
> > > self-contained.
> > 
> > I've added kOsMacYosemite flag to gpu_test_expectations_parser.cc file.
> > Could you check this CL again?
> > Thanks!
> 
> How about adding some Mac tests to gpu_test_expectations_parser_unittest.cc,
in
> particular a test making sure the "yosemite" flag is working?

OK, will do!

[Andrey Kraynov, 2015-04-14 14:15:26]

> How about adding some Mac tests to gpu_test_expectations_parser_unittest.cc,
in
> particular a test making sure the "yosemite" flag is working?

I tried to generalize some GPUTestExpectationsParser tests and now all known
OSes should be tested, not only Win7 + Yosemite.
Hope that it wouldn't be too complex for that CL.

[Ken Russell (switch to Gerrit), 2015-04-15 01:01:29]

On 2015/04/14 14:15:26, Andrey Kraynov wrote:
> > How about adding some Mac tests to gpu_test_expectations_parser_unittest.cc,
> in
> > particular a test making sure the "yosemite" flag is working?
> 
> I tried to generalize some GPUTestExpectationsParser tests and now all known
> OSes should be tested, not only Win7 + Yosemite.
> Hope that it wouldn't be too complex for that CL.

That's very nice. Thank you for being so through. LGTM

[zmo, 2015-04-15 01:14:08]

LGTM

[Andrey Kraynov, 2015-04-15 08:06:48]

The CQ bit was checked by iceman@yandex-team.ru

[commit-bot: I haz the power, 2015-04-15 08:07:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1068813002/80001

[commit-bot: I haz the power, 2015-04-15 11:02:44]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-04-15 11:03:47]

Patchset 5 (id:??) landed as
https://crrev.com/3197ce8d01839ba9bb19a4b653c99b4f87eb64b5
Cr-Commit-Position: refs/heads/master@{#325221}