chrome/browser/printing/print_preview_pdf_generated_browsertest.cc - Issue 1068793002: Fixed "blocking io" from FixupPath on UI thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_preview_pdf_generated_browsertest.cc

Issue 1068793002: Fixed "blocking io" from FixupPath on UI thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed adding cwd aka "blocking IO" used in FixupURL via FilePathToFileURL, also fixed client code Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/printing/print_preview_pdf_generated_browsertest.cc

diff --git a/chrome/browser/printing/print_preview_pdf_generated_browsertest.cc b/chrome/browser/printing/print_preview_pdf_generated_browsertest.cc

index f6a93216df9a52a008c9271ab1b0f3fe5d658528..b040dfad89a481309a9321330644c100e41d620b 100644

--- a/chrome/browser/printing/print_preview_pdf_generated_browsertest.cc

+++ b/chrome/browser/printing/print_preview_pdf_generated_browsertest.cc

@@ -307,7 +307,7 @@ class PrintPreviewPdfGeneratedBrowserTest : public InProcessBrowserTest {

const PrintPreviewSettings& settings) {

print_preview_observer_->SetPrintPreviewSettings(settings);

base::FilePath path(file_name);

- GURL gurl = net::FilePathToFileURL(path);

+ GURL gurl = net::FilePathToFileURL(base::MakeAbsoluteFilePath(path));

ui_test_utils::NavigateToURL(browser(), gurl);