Fixed "blocking io" from FixupPath on UI thread.

chromecast/browser/service/cast_service_simple.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/browser/service/cast_service_simple.h"
 
 #include "base/command_line.h"
+#include "base/files/file_util.h"
 #include "chromecast/browser/cast_content_window.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
 #include "net/base/filename_util.h"
 #include "net/url_request/url_request_context_getter.h"
 
 namespace chromecast {
 
 namespace {
 
 GURL GetStartupURL() {
   base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
   const base::CommandLine::StringVector& args = command_line->GetArgs();
 
   if (args.empty())
     return GURL("http://www.google.com/");
 
   GURL url(args[0]);
   if (url.is_valid() && url.has_scheme())
     return url;
 
-  return net::FilePathToFileURL(base::FilePath(args[0]));
+  return net::FilePathToFileURL(

[Peter Kasting, 2015/04/22 22:40:04]

Both this and shell_browser_main_parts.cc should be using the safer form I noted
in my last review comments, which correctly handles the case where an invalid
path is passed in.

+      base::MakeAbsoluteFilePath(base::FilePath(args[0])));
 }
 
 }  // namespace
 
 // static
 scoped_ptr<CastService> CastService::Create(
     content::BrowserContext* browser_context,
     PrefService* pref_service,
     metrics::CastMetricsServiceClient* metrics_service_client,
     net::URLRequestContextGetter* request_context_getter) {
@@ skipping 20 matching lines @@
 }
 
 void CastServiceSimple::StartInternal() {
   // This is the simple version that hard-codes the size.
   gfx::Size initial_size(1280, 720);
 
   window_.reset(new CastContentWindow);
   web_contents_ = window_->CreateWebContents(initial_size, browser_context());
   window_->CreateWindowTree(initial_size, web_contents_.get());
 
   web_contents_->GetController().LoadURL(startup_url_, content::Referrer(),

[Peter Kasting, 2015/04/22 22:40:04]

This call should be guarded by an "if (startup_url_.is_valid()) {" check.

                                          ui::PAGE_TRANSITION_TYPED,
                                          std::string());
 }
 
 void CastServiceSimple::StopInternal() {
   web_contents_->GetRenderViewHost()->ClosePage();
   web_contents_.reset();
   window_.reset();
 }
 
 }  // namespace chromecast