Fixed "blocking io" from FixupPath on UI thread.

net/base/filename_util.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/filename_util.h"
 
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/path_service.h"
 #include "base/strings/string_util.h"
@@ skipping 45 matching lines @@
       &url_string, 0, FILE_PATH_LITERAL("?"), FILE_PATH_LITERAL("%3F"));
 
 #if defined(OS_POSIX)
   ReplaceSubstringsAfterOffset(
       &url_string, 0, FILE_PATH_LITERAL("\\"), FILE_PATH_LITERAL("%5C"));
 #endif
 
   return GURL(url_string);
 }
 
+GURL FilePathToFileURLNoCWD(const base::FilePath& path) {
+  // Produce a URL like "file:///C:/foo" for a regular file, or
+  // "file://///server/path" for UNC. The URL canonicalizer will fix up the
+  // latter case to be the canonical UNC form: "file://server/path"
+  base::FilePath::StringType url_string(kFileURLPrefix);
+  url_string.append(path.value());
+  // Do replacement of some characters. Since we assume the input is a
+  // literal filename, anything the URL parser might consider special should
+  // be escaped here.
+
+  // must be the first substitution since others will introduce percents as the
+  // escape character
+  ReplaceSubstringsAfterOffset(&url_string, 0, FILE_PATH_LITERAL("%"),
+                               FILE_PATH_LITERAL("%25"));
+
+  // semicolon is supposed to be some kind of separator according to RFC 2396
+  ReplaceSubstringsAfterOffset(&url_string, 0, FILE_PATH_LITERAL(";"),
+                               FILE_PATH_LITERAL("%3B"));
+
+  ReplaceSubstringsAfterOffset(&url_string, 0, FILE_PATH_LITERAL("#"),
+                               FILE_PATH_LITERAL("%23"));
+
+  ReplaceSubstringsAfterOffset(&url_string, 0, FILE_PATH_LITERAL("?"),
+                               FILE_PATH_LITERAL("%3F"));
+
+#if defined(OS_POSIX)
+  ReplaceSubstringsAfterOffset(&url_string, 0, FILE_PATH_LITERAL("\\"),
+                               FILE_PATH_LITERAL("%5C"));
+#endif

[davidben, 2015/04/14 16:26:22]

This is too much code to be duplicated. Move things to a helper function.

+
+  return GURL(url_string);
+}
+
 bool FileURLToFilePath(const GURL& url, base::FilePath* file_path) {
   *file_path = base::FilePath();
   base::FilePath::StringType& file_path_str =
       const_cast<base::FilePath::StringType&>(file_path->value());
   file_path_str.clear();
 
   if (!url.is_valid())
     return false;
 
 #if defined(OS_WIN)
@@ skipping 77 matching lines @@
     if (file_path->value() == base::FilePath::kCurrentDirectory) {
       *file_path = base::FilePath(leaf_name);
     } else {
       *file_path = file_path->Append(leaf_name);
     }
   }
 #endif
 }
 
 }  // namespace net