Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 1068783006: Bump limit in PushStackTraceAndDie (Closed)

Created:
5 years, 8 months ago by Jakob Kummerow
Modified:
5 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Bump limit in PushStackTraceAndDie To increase the chances of minidumps containing enough useful information R=yangguo@chromium.org Committed: https://crrev.com/30cc37e9ac5ac3049dd4c39ab5e18de577ea002a Cr-Commit-Position: refs/heads/master@{#27915}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Jakob Kummerow
PTAL.
5 years, 8 months ago (2015-04-17 11:20:34 UTC) #1
Yang
On 2015/04/17 11:20:34, Jakob wrote: > PTAL. lgtm.
5 years, 8 months ago (2015-04-17 11:22:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068783006/1
5 years, 8 months ago (2015-04-17 11:22:53 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-17 11:46:06 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 11:46:20 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30cc37e9ac5ac3049dd4c39ab5e18de577ea002a
Cr-Commit-Position: refs/heads/master@{#27915}

Powered by Google App Engine
This is Rietveld 408576698