Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: webkit/port/bindings/v8/ScriptController.cpp

Issue 10687: Clean up the proxy code for handling frame navigation.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/port/bindings/v8/ScriptController.cpp
===================================================================
--- webkit/port/bindings/v8/ScriptController.cpp (revision 5350)
+++ webkit/port/bindings/v8/ScriptController.cpp (working copy)
@@ -323,11 +323,6 @@
m_proxy->finishedWithEvent(evt);
}
-void ScriptController::clearDocumentWrapper()
-{
- m_proxy->clearDocumentWrapper();
-}
-
// Create a V8 object with an interceptor of NPObjectPropertyGetter
void ScriptController::BindToWindowObject(Frame* frame, const String& key, NPObject* object)
{
@@ -512,6 +507,9 @@
void ScriptController::clearWindowShell()
{
+ // V8 binding expects ScriptController::clearWindowShell only be called
+ // when a frame is loading a new page. V8Proxy::clearForNavigation
+ // creates a new context for the new page.
m_proxy->clearForNavigation();
}
@@ -522,9 +520,7 @@
void ScriptController::updateDocument()
{
- // TODO(eseidel): Should update document property on current window object
- // and all previous window objects which may still be alive.
- notImplemented();
+ m_proxy->updateDocument();
}

Powered by Google App Engine
This is Rietveld 408576698