Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 10687: Clean up the proxy code for handling frame navigation.... (Closed)

Created:
12 years, 1 month ago by Feng Qian
Modified:
9 years, 7 months ago
Reviewers:
Mike Belshe
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Clean up the proxy code for handling frame navigation. When a frame navigates to a new page, the old context handle is disposed, and the global proxy object is detached from the old context. A new context is created using the global proxy object. However, the security token is not created because, at this point, the security origin is not updated to new URL. When the new document is ready, V8Proxy updates the security token using the security origin of the document. Our code relies on the fact that ScriptController::clearWindowShell be called only when the frame loads a page, but not at closing time. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5396

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -110 lines) Patch
M webkit/port/bindings/v8/ScriptController.h View 2 chunks +0 lines, -2 lines 0 comments Download
M webkit/port/bindings/v8/ScriptController.cpp View 3 chunks +4 lines, -8 lines 0 comments Download
M webkit/port/bindings/v8/v8_proxy.h View 5 chunks +4 lines, -13 lines 0 comments Download
M webkit/port/bindings/v8/v8_proxy.cpp View 9 chunks +55 lines, -87 lines 4 comments Download

Messages

Total messages: 3 (0 generated)
Feng Qian
12 years, 1 month ago (2008-11-13 17:47:54 UTC) #1
Mike Belshe
lgtm http://codereview.chromium.org/10687/diff/1/4 File webkit/port/bindings/v8/v8_proxy.cpp (right): http://codereview.chromium.org/10687/diff/1/4#newcode1645 Line 1645: extra line http://codereview.chromium.org/10687/diff/1/4#newcode1659 Line 1659: { v8::HandleScope ...
12 years, 1 month ago (2008-11-13 18:13:49 UTC) #2
Feng Qian
12 years, 1 month ago (2008-11-13 21:30:18 UTC) #3
http://codereview.chromium.org/10687/diff/1/4
File webkit/port/bindings/v8/v8_proxy.cpp (right):

http://codereview.chromium.org/10687/diff/1/4#newcode1645
Line 1645: 
On 2008/11/13 18:13:50, mbelshe wrote:
> extra line
> 
> 

Done.

http://codereview.chromium.org/10687/diff/1/4#newcode1659
Line 1659: {   v8::HandleScope scope;
On 2008/11/13 18:13:50, mbelshe wrote:
> funky braces
> 
> 

Done.

Powered by Google App Engine
This is Rietveld 408576698