Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1068693003: Fixing crash on chrome profiler on generating html trace. (Closed)

Created:
5 years, 8 months ago by ssid
Modified:
5 years, 8 months ago
Reviewers:
Sami
CC:
picksi1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing crash on chrome profiler on generating html trace. The chrome profiler opens file without utf-8 encoding, so the html trace file was not getting generated. This CL changes the file opening to have utf-8 encoding. BUG=477295 Committed: https://crrev.com/723a007e43d66c624b6cff92f11b7e1ccab4b904 Cr-Commit-Position: refs/heads/master@{#325230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/profile_chrome/trace_packager.py View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
ssid
Small fix, PTAL.
5 years, 8 months ago (2015-04-15 11:53:46 UTC) #2
Sami
Thanks for the quick fix! lgtm.
5 years, 8 months ago (2015-04-15 12:02:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068693003/1
5 years, 8 months ago (2015-04-15 12:03:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 12:29:46 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 12:30:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/723a007e43d66c624b6cff92f11b7e1ccab4b904
Cr-Commit-Position: refs/heads/master@{#325230}

Powered by Google App Engine
This is Rietveld 408576698