sky/engine/core/rendering/RenderFlexibleBox.h - Issue 1068683002: Delete RenderBlockFlow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderFlexibleBox.h

Issue 1068683002: Delete RenderBlockFlow. (Closed) Base URL: https://github.com/domokit/mojo.git@block

Patch Set: Remove unused float-related code instead of moving it. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderFlexibleBox.h

diff --git a/sky/engine/core/rendering/RenderFlexibleBox.h b/sky/engine/core/rendering/RenderFlexibleBox.h

index 634adcc5d36893b6d341ca9ef8ba17f54643a047..ef1055fc07787a9465fbb6af6238ba72f0f29526 100644

--- a/sky/engine/core/rendering/RenderFlexibleBox.h

+++ b/sky/engine/core/rendering/RenderFlexibleBox.h

@@ -38,7 +38,7 @@ namespace blink {

class RenderFlexibleBox : public RenderBlock {

public:

- RenderFlexibleBox(Element*);

+ RenderFlexibleBox(ContainerNode*);

virtual ~RenderFlexibleBox();

static RenderFlexibleBox* createAnonymous(Document*);

@@ -46,7 +46,7 @@ public:

virtual const char* renderName() const override;

virtual bool isFlexibleBox() const override final { return true; }

- void layout() final;

+ void layout();

virtual int baselinePosition(FontBaseline, bool firstLine, LineDirectionMode, LinePositionMode = PositionOnContainingLine) const override;

virtual int firstLineBoxBaseline() const override;