ui/file_manager/integration_tests/file_manager/suggest_app_dialog.js - Issue 1068653002: Extract some logic from SuggestAppsDialog to a separate class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/integration_tests/file_manager/suggest_app_dialog.js

Issue 1068653002: Extract some logic from SuggestAppsDialog to a separate class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/file_manager/integration_tests/file_manager/suggest_app_dialog.js

diff --git a/ui/file_manager/integration_tests/file_manager/suggest_app_dialog.js b/ui/file_manager/integration_tests/file_manager/suggest_app_dialog.js

index 58b4b5dc483bfd4348675bd28b0c6ba88ec45817..981c807fcc6b6c7418545c691803f255c71372fc 100644

--- a/ui/file_manager/integration_tests/file_manager/suggest_app_dialog.js

+++ b/ui/file_manager/integration_tests/file_manager/suggest_app_dialog.js

@@ -53,7 +53,7 @@ testcase.suggestAppDialog = function() {

function(result) {

chrome.test.assertTrue(!!result);

remoteCall.waitForElement(

- appId, '#suggest-app-dialog:not(.show-spinner)').

+ appId, '#suggest-app-dialog #webview-container:not(.show-spinner)').

then(this.next);

// Override task APIs for test.

« no previous file with comments | « ui/file_manager/file_manager/main.html ('k') | no next file » | no next file with comments »