ui/file_manager/file_manager/foreground/js/file_manager_commands.js - Issue 1068653002: Extract some logic from SuggestAppsDialog to a separate class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/file_manager_commands.js

Issue 1068653002: Extract some logic from SuggestAppsDialog to a separate class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/file_manager/foreground/js/cws_widget_container.js ('k') | ui/file_manager/file_manager/foreground/js/main_scripts.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/js/file_manager_commands.js

diff --git a/ui/file_manager/file_manager/foreground/js/file_manager_commands.js b/ui/file_manager/file_manager/foreground/js/file_manager_commands.js

index 980f2887a3b0b286222b4f4c7262d9c6baf87769..070b1cd2a93356d6318997bda1e8c57df07a7089 100644

--- a/ui/file_manager/file_manager/foreground/js/file_manager_commands.js

+++ b/ui/file_manager/file_manager/foreground/js/file_manager_commands.js

@@ -1257,7 +1257,7 @@ CommandHandler.COMMANDS_['add-new-services'] = /** @type {Command} */ ({

function(result, itemId) {

// If a new provider is installed, then launch it so the configuration

// dialog is shown (if it's available).

- if (result === SuggestAppsDialog.Result.INSTALL_SUCCESSFUL)

+ if (result === SuggestAppsDialog.Result.SUCCESS)

chrome.management.launchApp(assert(itemId), function() {});

});