android_webview/test/shell/AndroidManifest.xml - Issue 1068633002: Make webview test apks installable on ICS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/test/shell/AndroidManifest.xml

Issue 1068633002: Make webview test apks installable on ICS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bug number in manifest file Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/test/shell/AndroidManifest.xml

diff --git a/android_webview/test/shell/AndroidManifest.xml b/android_webview/test/shell/AndroidManifest.xml

index b9666992f192a8eb90621e75ee3d1c6eb79c0d66..360b91545e38f1a9e538cf13d4ec92dfda5f5b1f 100644

--- a/android_webview/test/shell/AndroidManifest.xml

+++ b/android_webview/test/shell/AndroidManifest.xml

@@ -8,7 +8,9 @@

<manifest xmlns:android="http://schemas.android.com/apk/res/android"

package="org.chromium.android_webview.shell">

- <uses-sdk android:minSdkVersion="19" android:targetSdkVersion="21" />

+ <!-- TODO(boliu): Change minSdkVersion to 19 when bots no longer try

+ to install webview apks on < K devices. crbug.com/474374 -->

+ <uses-sdk android:minSdkVersion="14" android:targetSdkVersion="21" />

<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>

<uses-permission android:name="android.permission.INTERNET"/>

<uses-permission android:name="android.permission.WAKE_LOCK"/>