Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1068633002: Make webview test apks installable on ICS (Closed)

Created:
5 years, 8 months ago by boliu
Modified:
5 years, 8 months ago
CC:
android-webview-reviews_chromium.org, chromium-reviews, Torne
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make webview test apks installable on JB This is to unbreak the some fyi bots, where failing to install the webview test apks causes the whole run to be aborted. All webview tests are annotated with @MinAndroidSdkLevel(Build.VERSION_CODES.KITKAT) so in theory they should never run on those older bots anyway. BUG=474374 Committed: https://crrev.com/176670201c8e531c3d91a6a2ee08b0478df472a5 Cr-Commit-Position: refs/heads/master@{#323989}

Patch Set 1 #

Patch Set 2 : bug number in manifest file #

Total comments: 1

Patch Set 3 : JB #

Patch Set 4 : build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M android_webview/javatests/AndroidManifest.xml View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/MultipleVideosTest.java View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M android_webview/test/shell/AndroidManifest.xml View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
boliu
5 years, 8 months ago (2015-04-06 23:41:39 UTC) #2
boliu
On 2015/04/06 23:41:39, boliu wrote: Damn it, bug number..
5 years, 8 months ago (2015-04-06 23:42:10 UTC) #3
boliu
Ok, fixed
5 years, 8 months ago (2015-04-06 23:43:01 UTC) #4
aurimas (slooooooooow)
https://codereview.chromium.org/1068633002/diff/20001/android_webview/javatests/AndroidManifest.xml File android_webview/javatests/AndroidManifest.xml (right): https://codereview.chromium.org/1068633002/diff/20001/android_webview/javatests/AndroidManifest.xml#newcode9 android_webview/javatests/AndroidManifest.xml:9: <uses-sdk android:minSdkVersion="14" android:targetSdkVersion="21" /> Lowest supported API level is ...
5 years, 8 months ago (2015-04-06 23:44:24 UTC) #5
aurimas (slooooooooow)
lgtm
5 years, 8 months ago (2015-04-06 23:44:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068633002/60001
5 years, 8 months ago (2015-04-06 23:56:35 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-07 00:24:04 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 00:24:51 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/176670201c8e531c3d91a6a2ee08b0478df472a5
Cr-Commit-Position: refs/heads/master@{#323989}

Powered by Google App Engine
This is Rietveld 408576698