Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 106863002: Fix compilation with clang (Closed)

Created:
7 years ago by Jakob Kummerow
Modified:
7 years ago
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -89 lines) Patch
M src/arm/codegen-arm.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M src/assembler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M src/cached-powers.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/date.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap-snapshot-generator.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/ia32/stub-cache-ia32.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/scanner-character-streams.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/x64/stub-cache-x64.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +0 lines, -59 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jakob Kummerow
PTAL.
7 years ago (2013-12-06 08:05:35 UTC) #1
Benedikt Meurer
LGTM
7 years ago (2013-12-06 08:08:57 UTC) #2
Dmitry Lomov (no reviews)
sheriff's note: ok to land this cleanup patch
7 years ago (2013-12-06 11:37:23 UTC) #3
Jakob Kummerow
7 years ago (2013-12-06 11:45:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r18267.

Powered by Google App Engine
This is Rietveld 408576698