tools/gn: provide better error message for bogus binary expressions

tools/gn/parser_unittest.cc

Index: tools/gn/parser_unittest.cc
diff --git a/tools/gn/parser_unittest.cc b/tools/gn/parser_unittest.cc
index 6216ee4d6b178a06a91092593be0896093f7a247..f5adb04ac679e4c269182d50ea2869320f2b0833 100644
--- a/tools/gn/parser_unittest.cc
+++ b/tools/gn/parser_unittest.cc
@@ -204,7 +204,7 @@ TEST(Parser, List) {
       " LITERAL(3)\n"
       " LITERAL(4)\n");
 
-  DoExpressionErrorTest("[a, 2+,]", 1, 6);
+  DoExpressionErrorTest("[a, 2+,]", 1, 7);

[mdempsky, 2015/04/06 23:41:51]

This expectation change is because GN used to give an error like:

    ERROR at //BUILD.gn:6:6: Expected right hand side for '+'
    [a, 2+,]
         ^

but now it instead says:

    ERROR at //BUILD.gn:6:7: Unexpected token ','
    [a, 2+,]
          ^

As mentioned in the bug, this is arguably a worse error message, but it seems to
be in-line with what C++ developers should be accustomed to from compiler error
messages for invalid input like this.

   DoExpressionErrorTest("[,]", 1, 2);
   DoExpressionErrorTest("[a,,]", 1, 4);
 }
@@ -243,6 +243,9 @@ TEST(Parser, Accessor) {
                     "   LITERAL(2)\n");
   DoParserErrorTest("a = b.c.d", 1, 6);  // Can't nest accessors (currently).
   DoParserErrorTest("a.b = 5", 1, 1);  // Can't assign to accessors (currently).
+
+  // Error at the bad dot in the RHS, not the + operator (crbug.com/472038).
+  DoParserErrorTest("foo(a + b.c.d)", 1, 10);
 }
 
 TEST(Parser, Condition) {