Add the ability to build Chrome tools to the Win Clang build script.

Add the ability to build Chrome tools to the Win Clang build script.

BUG=424436, 467287
Committed: https://crrev.com/475949d9430b6a759ce759f2133dd3a1577d0d0b
Cr-Commit-Position: refs/heads/master@{#324089}

Committed: https://crrev.com/8caa594c291b6dd3e35d60a886ef33b36ae78e97
Cr-Commit-Position: refs/heads/master@{#324164}

Committed: https://crrev.com/a04d4f9ffc4d88bde9450c410d814ffe35b03f44
Cr-Commit-Position: refs/heads/master@{#324286}

[dcheng, 2015-04-06 23:09:09]

dcheng@chromium.org changed reviewers:
+ hans@chromium.org

[dcheng, 2015-04-06 23:09:10]

I haven't really figured out what I'm going to do for the plugin on Windows yet,
but this is vaguely on the path =)

https://codereview.chromium.org/1068603002/diff/1/tools/clang/scripts/update.py
File tools/clang/scripts/update.py (right):

https://codereview.chromium.org/1068603002/diff/1/tools/clang/scripts/update....
tools/clang/scripts/update.py:313: parser.add_argument('--no-clobber',
dest='clobber', action='store_false')
I added this argument, because it makes tool testing a bit difficult otherwise
(since it constantly blows away the compile DB / intermediate build artifacts
that source files might depend on). I think in this mode, it'd be nice to
suppress updating the LLVM repo too, but I'm not sure what a good name for that
flag is... or if I should just add a separate flag for that.

[Nico, 2015-04-07 04:18:54]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-04-07 04:18:55]

Looks like a step in the right direction to me, lgtm. Hans is away until
Wednesday – you can wait until he's back to get a review from someone who knows
what they're doing, or land with my lg and risk getting a "you need to rewrite
all the things" comment when Hans is back :-)

https://codereview.chromium.org/1068603002/diff/1/tools/clang/scripts/update.py
File tools/clang/scripts/update.py (right):

https://codereview.chromium.org/1068603002/diff/1/tools/clang/scripts/update....
tools/clang/scripts/update.py:145: Note that the shim directory name
intentionally has no _ or _. The implicit
_ or _?

https://codereview.chromium.org/1068603002/diff/1/tools/clang/scripts/update....
tools/clang/scripts/update.py:146: tool detection logic munges them in a weird
way."""
assert not '_'in CHROME_TOOLS_SHIM_DIR
?

https://codereview.chromium.org/1068603002/diff/1/tools/clang/scripts/update....
tools/clang/scripts/update.py:148: with file(os.path.join(CHROME_TOOLS_SHIM_DIR,
'CMakeLists.txt'), 'w') as f:
f.write('# Automatically generated by tools/clang/scripts/update.py. Do not
edit')

https://codereview.chromium.org/1068603002/diff/1/tools/clang/scripts/update....
tools/clang/scripts/update.py:149: f.write("# Since tools/clang isn't actually a
subdirectory, use the two\n")
nit: single quotes

[dcheng, 2015-04-07 07:22:54]

https://codereview.chromium.org/1068603002/diff/1/tools/clang/scripts/update.py
File tools/clang/scripts/update.py (right):

https://codereview.chromium.org/1068603002/diff/1/tools/clang/scripts/update....
tools/clang/scripts/update.py:145: Note that the shim directory name
intentionally has no _ or _. The implicit
On 2015/04/07 04:18:55, Nico wrote:
> _ or _?

Hmm. I copy pasted this from update.sh... and sure enough, the same typo is
there!

Fixed here for now. Will fix the other one when I get a chance.

https://codereview.chromium.org/1068603002/diff/1/tools/clang/scripts/update....
tools/clang/scripts/update.py:146: tool detection logic munges them in a weird
way."""
On 2015/04/07 at 04:18:55, Nico wrote:
> assert not '_'in CHROME_TOOLS_SHIM_DIR
> ?

Done.

https://codereview.chromium.org/1068603002/diff/1/tools/clang/scripts/update....
tools/clang/scripts/update.py:148: with file(os.path.join(CHROME_TOOLS_SHIM_DIR,
'CMakeLists.txt'), 'w') as f:
On 2015/04/07 at 04:18:55, Nico wrote:
> f.write('# Automatically generated by tools/clang/scripts/update.py. Do not
edit')

Done.

https://codereview.chromium.org/1068603002/diff/1/tools/clang/scripts/update....
tools/clang/scripts/update.py:149: f.write("# Since tools/clang isn't actually a
subdirectory, use the two\n")
On 2015/04/07 04:18:55, Nico wrote:
> nit: single quotes

Rephrased the text to avoid single quotes so I switched these strings to use
single quotes now.

[dcheng, 2015-04-07 17:45:41]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2015-04-07 17:45:41]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1068603002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2015-04-07 17:46:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1068603002/20001

[commit-bot: I haz the power, 2015-04-07 19:25:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-07 19:26:06]

Patchset 2 (id:??) landed as
https://crrev.com/475949d9430b6a759ce759f2133dd3a1577d0d0b
Cr-Commit-Position: refs/heads/master@{#324089}

[Nico, 2015-04-07 22:36:46]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1063273002/ by thakis@chromium.org.

The reason for reverting is: Broke all bots on
http://build.chromium.org/p/chromium.fyi/console?category=win%20clang , they
fail with:

________ running 'C:\b\depot_tools\python276_bin\python.exe
src/tools/clang/scripts/update.py --if-needed' in
'C:\b\build\slave\CrWinClang\build'
usage: update.py [-h] [--no-clobber] [--tools [TOOLS [TOOLS ...]]]
update.py: error: unrecognized arguments: --if-needed

Probably easy to fix (just add a dummy --if-needed parameter to argparse), but
reverting to get that waterfall back to green..

[dcheng, 2015-04-07 23:09:14]

PTAL. Added the dummy flag, since it might be useful in the future. I tested
that gclient runhooks doesn't fail with build/gyp_chromium -Dclang=1

[Nico, 2015-04-07 23:16:59]

On 2015/04/07 23:09:14, dcheng wrote:
> PTAL. Added the dummy flag, since it might be useful in the future. I tested
> that gclient runhooks doesn't fail with build/gyp_chromium -Dclang=1

Lgtm, thanks. Please keep an eye on the clang FYI waterfall after this goes in.

[dcheng, 2015-04-07 23:17:43]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2015-04-07 23:18:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1068603002/40001

[commit-bot: I haz the power, 2015-04-08 01:10:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-08 01:11:08]

Patchset 3 (id:??) landed as
https://crrev.com/8caa594c291b6dd3e35d60a886ef33b36ae78e97
Cr-Commit-Position: refs/heads/master@{#324164}

[Nico, 2015-04-08 02:31:58]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1070523002/ by thakis@chromium.org.

The reason for reverting is: Still breaks clang/win bots:
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/279.

[dcheng, 2015-04-08 17:46:32]

PTAL =(

[hans, 2015-04-08 17:59:31]

lgtm

[dcheng, 2015-04-08 18:37:04]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2015-04-08 18:37:05]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1068603002/#ps60001
(title: "Rather embarrassed")

[commit-bot: I haz the power, 2015-04-08 18:38:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1068603002/60001

[commit-bot: I haz the power, 2015-04-08 21:24:11]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-08 21:25:06]

Patchset 4 (id:??) landed as
https://crrev.com/a04d4f9ffc4d88bde9450c410d814ffe35b03f44
Cr-Commit-Position: refs/heads/master@{#324286}