Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1068593002: printing: Use MD5DigestToBase16() to get a human-readable hexadecimal string. (Closed)

Created:
5 years, 8 months ago by tfarina
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

printing: Use MD5DigestToBase16() to get a human-readable hexadecimal string. It seems better to use a specific MD5 API for this kind of thing. The result should be the same with the difference that the alpha chars used in MD5DigestToBase16() are lowercase. BUG=None TEST=components_browsertests --gtest_filter=PrintWebViewHelperTest.PrintLayoutTest R=vitalybuka@chromium.org Committed: https://crrev.com/0a9c25c5a7f8cec0699401bb0328dd6df9d9cb13 Cr-Commit-Position: refs/heads/master@{#324186}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M printing/image.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
Is this OK? ptal
5 years, 8 months ago (2015-04-06 23:56:05 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm
5 years, 8 months ago (2015-04-07 00:14:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068593002/1
5 years, 8 months ago (2015-04-08 02:22:16 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-08 04:44:36 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 04:45:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a9c25c5a7f8cec0699401bb0328dd6df9d9cb13
Cr-Commit-Position: refs/heads/master@{#324186}

Powered by Google App Engine
This is Rietveld 408576698