src/x64/code-stubs-x64.cc - Issue 106853002: Use FAR jump in GenerateCompareFlatAsciiStrings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/code-stubs-x64.cc

Issue 106853002: Use FAR jump in GenerateCompareFlatAsciiStrings. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: CR feedback for landing Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/code-stubs-x64.cc

diff --git a/src/x64/code-stubs-x64.cc b/src/x64/code-stubs-x64.cc

index 2f6585641a391e7f430041266614b8c06f8c1c93..d04e976e0dbe3e21c7434d3c2ad51c9591f2cd9e 100644

--- a/src/x64/code-stubs-x64.cc

+++ b/src/x64/code-stubs-x64.cc

@@ -4335,7 +4335,10 @@ void StringCompareStub::GenerateCompareFlatAsciiStrings(MacroAssembler* masm,

// Compare loop.

Label result_not_equal;

GenerateAsciiCharsCompareLoop(masm, left, right, min_length, scratch2,

- &result_not_equal, Label::kNear);

+ &result_not_equal,

+ // In debug-code mode, SmiTest below might push

+ // the target label outside the near range.

+ Label::kFar);

// Completed loop without finding different characters.

// Compare lengths (precomputed).

« no previous file with comments | « no previous file | no next file » | no next file with comments »