 Chromium Code Reviews
 Chromium Code Reviews Issue 106853002:
  Use  FAR jump in GenerateCompareFlatAsciiStrings.  (Closed) 
  Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
    
  
    Issue 106853002:
  Use  FAR jump in GenerateCompareFlatAsciiStrings.  (Closed) 
  Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge| Index: src/x64/code-stubs-x64.cc | 
| diff --git a/src/x64/code-stubs-x64.cc b/src/x64/code-stubs-x64.cc | 
| index 2f6585641a391e7f430041266614b8c06f8c1c93..45d6fe375be6c1e64f9384f32795446baf76096c 100644 | 
| --- a/src/x64/code-stubs-x64.cc | 
| +++ b/src/x64/code-stubs-x64.cc | 
| @@ -4335,7 +4335,10 @@ void StringCompareStub::GenerateCompareFlatAsciiStrings(MacroAssembler* masm, | 
| // Compare loop. | 
| Label result_not_equal; | 
| GenerateAsciiCharsCompareLoop(masm, left, right, min_length, scratch2, | 
| - &result_not_equal, Label::kNear); | 
| + &result_not_equal, | 
| + // In debug-code mode, SmiTest below might push | 
| + // the target label outside the near range. | 
| + FLAG_debug_code ? Label::kFar : Label::kNear); | 
| 
Jakob Kummerow
2013/12/06 09:08:38
nit: I'd prefer to keep the effect of FLAG_debug_c
 | 
| // Completed loop without finding different characters. | 
| // Compare lengths (precomputed). |