Use FAR jump in GenerateCompareFlatAsciiStrings.

Use  FAR jump in GenerateCompareFlatAsciiStrings.

BUG=325487
R=jkummerow@chromium.org
LOG=N

Committed: https://code.google.com/p/v8/source/detail?r=18288

[Jakob Kummerow, 2013-12-06 09:08:38]

LGTM with comment.

Since the bug is about a test-only failure, I've also set LOG=N.

https://codereview.chromium.org/106853002/diff/1/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):

https://codereview.chromium.org/106853002/diff/1/src/x64/code-stubs-x64.cc#ne...
src/x64/code-stubs-x64.cc:4341: FLAG_debug_code ? Label::kFar : Label::kNear);
nit: I'd prefer to keep the effect of FLAG_debug_code on emitted code to a
minimum. Let's just always use Label::kFar here. (Since that's the default, you
can also just skip the explicit parameter; but please do keep the comment to
warn future contributors.)

[titzer, 2013-12-10 13:23:11]

On 2013/12/06 09:08:38, Jakob wrote:
> LGTM with comment.
> 
> Since the bug is about a test-only failure, I've also set LOG=N.
> 
> https://codereview.chromium.org/106853002/diff/1/src/x64/code-stubs-x64.cc
> File src/x64/code-stubs-x64.cc (right):
> 
>
https://codereview.chromium.org/106853002/diff/1/src/x64/code-stubs-x64.cc#ne...
> src/x64/code-stubs-x64.cc:4341: FLAG_debug_code ? Label::kFar : Label::kNear);
> nit: I'd prefer to keep the effect of FLAG_debug_code on emitted code to a
> minimum. Let's just always use Label::kFar here. (Since that's the default,
you
> can also just skip the explicit parameter; but please do keep the comment to
> warn future contributors.)

Sheriff's note: permission to land

[Dmitry Lomov (no reviews), 2013-12-10 14:28:48]

Committed patchset #2 manually as r18288.