Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1068493003: Removed old SDCH ProblemCode constants that are no longer being used in UMA. (Closed)

Created:
5 years, 8 months ago by Randy Smith (Not in Mondays)
Modified:
5 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed old SDCH ProblemCode constants that are no longer being used in UMA. BUG=None R=ellyjones@chromium.org Committed: https://crrev.com/3867cad4c27eaf5e3946ea3e28a0468d579d2fca Cr-Commit-Position: refs/heads/master@{#324241}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M net/base/sdch_problem_code_list.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Randy Smith (Not in Mondays)
Elly: This is a little bit of cleanup I thought it was easier to just ...
5 years, 8 months ago (2015-04-06 20:38:53 UTC) #1
Elly Fong-Jones
lgtm
5 years, 8 months ago (2015-04-07 16:30:13 UTC) #2
Randy Smith (Not in Mondays)
Alexei: Stamp on histograms.xml?
5 years, 8 months ago (2015-04-07 17:49:05 UTC) #4
Alexei Svitkine (slow)
lgtm
5 years, 8 months ago (2015-04-07 18:42:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068493003/1
5 years, 8 months ago (2015-04-08 02:54:40 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/13892)
5 years, 8 months ago (2015-04-08 09:30:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068493003/1
5 years, 8 months ago (2015-04-08 15:18:48 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-08 17:05:54 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 17:07:49 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3867cad4c27eaf5e3946ea3e28a0468d579d2fca
Cr-Commit-Position: refs/heads/master@{#324241}

Powered by Google App Engine
This is Rietveld 408576698