Issue 1068443002: Clean up BlockRef

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1068443002: Clean up BlockRef (Closed)

Created:
5 years, 8 months ago by mtklein_C

Modified:
5 years, 8 months ago

Reviewers:
bungeman-skia, mtklein, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Clean up BlockRef - It's no longer needed to help the (2011?) transition to SkAutoTUnref. - It prevents us from making classes that go in SkAutoTUnrefs final, i.e. all ref-counted classes. This had better not have been public API... TBR=reed@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/76f5cc6e9e87ff247c3ef1f4b3fb03668db06e2e

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -24 lines)			Patch
	M	include/core/SkRefCnt.h	View	1	1 chunk	+1 line, -24 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068443002/20001

5 years, 8 months ago (2015-04-06 15:46:16 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-06 15:57:37 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/76f5cc6e9e87ff247c3ef1f4b3fb03668db06e2e