Issue 1068393002: remove CSS 'all' property.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1068393002: remove CSS 'all' property. (Closed)

Created:
5 years, 8 months ago by eseidel

Modified:
5 years, 8 months ago

Reviewers:
ojan

CC:
ojan, abarth-chromium, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

remove CSS 'all' property. The human mind is simply not capable of beholding the sheer power of the CSS 'all' property. We shall remove it now and leave its echo for generations to contemplate. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f585b6a53c65bf9c60b791dedb9ad2e08dfaacb2

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -71 lines)			Patch
M	sky/engine/core/css/CSSComputedStyleDeclaration.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sky/engine/core/css/CSSProperties.in	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sky/engine/core/css/CSSProperty.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/css/CSSProperty.cpp	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	sky/engine/core/css/parser/BisonCSSParser-in.cpp	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	sky/engine/core/css/parser/CSSPropertyParser.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/css/resolver/StyleResolver.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/css/resolver/StyleResolver.cpp	View	3 chunks	+1 line, -44 lines	0 comments	Download

Total messages: 2 (0 generated)

eseidel

5 years, 8 months ago (2015-04-08 20:39:52 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f585b6a53c65bf9c60b791dedb9ad2e08dfaacb2 (presubmit successful).