Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1068383005: Remove CSSPropertySpeak (Closed)

Created:
5 years, 8 months ago by eseidel
Modified:
5 years, 8 months ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove CSSPropertySpeak This does not belong in CSS in Sky. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c686f20350616357cdf4e9ee0129451fecd244cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -77 lines) Patch
M sky/engine/core/css/CSSComputedStyleDeclaration.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/CSSPrimitiveValueMappings.h View 2 chunks +0 lines, -50 lines 0 comments Download
M sky/engine/core/css/CSSProperties.in View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/CSSValueKeywords.in View 1 chunk +0 lines, -8 lines 0 comments Download
M sky/engine/core/css/parser/BisonCSSParser-in.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 3 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyleConstants.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/style/StyleRareInheritedData.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/style/StyleRareInheritedData.cpp View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
5 years, 8 months ago (2015-04-08 22:19:10 UTC) #1
ojan
lgtm
5 years, 8 months ago (2015-04-08 23:05:32 UTC) #2
eseidel
5 years, 8 months ago (2015-04-09 20:25:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c686f20350616357cdf4e9ee0129451fecd244cb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698