Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Issue 1068383002: Re-enable property tree verification for layout tests (Closed)

Created:
5 years, 8 months ago by ajuma
Modified:
5 years, 8 months ago
Reviewers:
Ian Vollick, Mike West
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, Ian Vollick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable property tree verification for layout tests Property tree verification was inadvertently disabled by http://crrev.com/976553002. This CL re-enables it. Committed: https://crrev.com/e1d84122d35e432848f4f8e9cc766cd40c6d88fb Cr-Commit-Position: refs/heads/master@{#324409}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/shell/app/shell_main_delegate.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ajuma
A regression crept in while verification was turned off; a fix for that is in ...
5 years, 8 months ago (2015-04-08 22:56:37 UTC) #2
Mike West
LGTM, assuming the bots are happy.
5 years, 8 months ago (2015-04-09 04:46:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068383002/1
5 years, 8 months ago (2015-04-09 10:51:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 11:01:06 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 11:01:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1d84122d35e432848f4f8e9cc766cd40c6d88fb
Cr-Commit-Position: refs/heads/master@{#324409}

Powered by Google App Engine
This is Rietveld 408576698