Issue 1068343003: SkPDF: ResourceDict replaced by factory function

Issue 1068343003: SkPDF: ResourceDict replaced by factory function (Closed)

Created:
5 years, 8 months ago by hal.canary

Modified:
5 years, 8 months ago

Reviewers:
tomhudson

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

SkPDF: ResourceDict replaced by factory function Motivation: Having a class here was unnecessary, since the only thing that set this class apart was how it is created, not how it behaves. BUG=skia:3585 Committed: https://skia.googlesource.com/skia/+/2b86155b42c2493ff0c558ce105a464769962274

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -137 lines)			Patch
M	src/doc/SkDocument_PDF.cpp	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	src/pdf/SkPDFDevice.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	src/pdf/SkPDFDevice.cpp	View	1	1 chunk	+11 lines, -35 lines	0 comments	Download
M	src/pdf/SkPDFFormXObject.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	src/pdf/SkPDFFormXObject.cpp	View		3 chunks	+2 lines, -3 lines	0 comments	Download
M	src/pdf/SkPDFResourceDict.h	View	1	3 chunks	+10 lines, -38 lines	0 comments	Download
M	src/pdf/SkPDFResourceDict.cpp	View	1	1 chunk	+46 lines, -40 lines	0 comments	Download
M	src/pdf/SkPDFShader.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pdf/SkPDFShader.cpp	View	1	4 chunks	+11 lines, -14 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068343003/20001

5 years, 8 months ago (2015-04-09 19:38:09 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-09 20:27:45 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2b86155b42c2493ff0c558ce105a464769962274