Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Side by Side Diff: pkg/compiler/lib/src/cps_ir/redundant_phi.dart

Issue 1068243002: Overhaul tree IR visitor and rename IR classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add dummy use for RootVisitor and InitializerVisitor without arguments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js.cps_ir.optimizers; 5 part of dart2js.cps_ir.optimizers;
6 6
7 /// Eliminate redundant phis from the given [FunctionDefinition]. 7 /// Eliminate redundant phis from the given [FunctionDefinition].
8 /// 8 ///
9 /// Phis in this case are [Continuations] together with corresponding 9 /// Phis in this case are [Continuations] together with corresponding
10 /// [InvokeContinuation]s. A [Continuation] parameter at position i is redundant 10 /// [InvokeContinuation]s. A [Continuation] parameter at position i is redundant
11 /// if for all [InvokeContinuation]s, the parameter at position i is identical 11 /// if for all [InvokeContinuation]s, the parameter at position i is identical
12 /// (except for feedback). Redundant parameters are removed from the 12 /// (except for feedback). Redundant parameters are removed from the
13 /// continuation signature, all invocations, and replaced within the 13 /// continuation signature, all invocations, and replaced within the
14 /// continuation body. 14 /// continuation body.
15 class RedundantPhiEliminator extends RecursiveVisitor with PassMixin { 15 class RedundantPhiEliminator extends RecursiveVisitor implements Pass {
16 String get passName => 'Redundant phi elimination'; 16 String get passName => 'Redundant phi elimination';
17 17
18 final Set<Continuation> workSet = new Set<Continuation>(); 18 final Set<Continuation> workSet = new Set<Continuation>();
19 19
20 @override 20 @override
21 void rewriteExecutableDefinition(final ExecutableDefinition root) { 21 void rewrite(RootNode root) {
22 if (root.isEmpty) return;
22 23
23 // Set all parent pointers. 24 // Set all parent pointers.
24 new ParentVisitor().visit(root); 25 new ParentVisitor().visit(root);
25 26
26 // Traverse the tree once to build the work set. 27 // Traverse the tree once to build the work set.
27 visit(root); 28 visit(root);
28 29
29 // Process each continuation one-by-one. 30 // Process each continuation one-by-one.
30 while (workSet.isNotEmpty) { 31 while (workSet.isNotEmpty) {
31 Continuation cont = workSet.first; 32 Continuation cont = workSet.first;
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 193
193 // Insert it just below the binding of definition. 194 // Insert it just below the binding of definition.
194 InteriorNode binding = definition.parent; 195 InteriorNode binding = definition.parent;
195 196
196 letCont.body = binding.body; 197 letCont.body = binding.body;
197 binding.body.parent = letCont; 198 binding.body.parent = letCont;
198 199
199 binding.body = letCont; 200 binding.body = letCont;
200 letCont.parent = binding; 201 letCont.parent = binding;
201 } 202 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/optimizers.dart ('k') | pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698