Overhaul tree IR visitor and rename IR classes.

pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library tree_ir_tracer;
 
 import 'dart:async' show EventSink;
 import '../tracer.dart';
 import 'tree_ir_nodes.dart';
 import 'optimization/optimization.dart';
@@ skipping 40 matching lines @@
   void _addGotoStatement(Block target) {
     blocks.last.statements.add(target);
   }
 
   void _addBlock(Block block) {
     block.index = blocks.length;
     block.catcher = catcher;
     blocks.add(block);
   }
 
-  void collect(ExecutableDefinition node) {
-    if (node.body != null) {
-      if (node is ConstructorDefinition) {
-        for (Initializer initializer in node.initializers) {
-          if (initializer is FieldInitializer) {
-            visitStatement(initializer.body);
-          }
-        }
-      }
-      visitStatement(node.body);
-    }
+  void collect(RootNode node) {
+    node.forEachBody(visitStatement);
   }
 
   visitLabeledStatement(LabeledStatement node) {
     Block target = new Block(node.label);
     breakTargets[node.label] = target;
     visitStatement(node.body);
     _addBlock(target);
     visitStatement(node.next);
   }
 
@@ skipping 94 matching lines @@
     visitStatement(node.next);
   }
 
   visitSetField(SetField node) {
     _addStatement(node);
     visitStatement(node.next);
   }
 
 }
 
-class TreeTracer extends TracerUtil with StatementVisitor, PassMixin {
+class TreeTracer extends TracerUtil with StatementVisitor {
   // TODO(asgerf): Fix visitors so we don't have to use PassMixin here.

[Kevin Millikin (Google), 2015/04/08 15:10:16]

I think you can remove this TODO.

[asgerf, 2015/04/09 09:58:23]

Done.

   String get passName => null;
 
   final EventSink<String> output;
 
   TreeTracer(this.output);
 
   Names names;
   BlockCollector collector;
   int statementCounter;
 
-  void traceGraph(String name, ExecutableDefinition node) {
-    if (node is FunctionDefinition && node.isAbstract) return;
-    if (node is FieldDefinition && node.body == null) return;
+  void traceGraph(String name, RootNode node) {
+    if (node.isEmpty) return;
     tag("cfg", () {
       printProperty("name", name);
-      rewrite(node);
+      printRootNode(node);
       collector.blocks.forEach(printBlock);
     });
   }
 
-  @override
-  void rewriteExecutableDefinition(ExecutableDefinition node) {
+  void printRootNode(RootNode node) {
     collector = new BlockCollector();
     names = new Names();
     statementCounter = 0;
     collector = new BlockCollector();
     collector.collect(node);
     collector.blocks.forEach(printBlock);
   }
 
   void printBlock(Block block) {
     tag("block", () {
@@ skipping 308 matching lines @@
       String prefix = v.element == null ? 'v' : '${v.element.name}_';
       while (name == null || _usedNames.contains(name)) {
         name = "$prefix${_counter++}";
       }
       _names[v] = name;
       _usedNames.add(name);
     }
     return name;
   }
 }