Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 106823003: Strip duplicates from browser_tests.isolate by completing chrome.isolate. (Closed)

Created:
7 years ago by M-A Ruel
Modified:
6 years, 11 months ago
CC:
chromium-reviews, Vadim Sh., Ken Russell (switch to Gerrit), jungshik at Google, ganetsky1, brettw, inferno, Martin Barbella, Nico, dtu
Visibility:
Public.

Description

Strip duplicates from browser_tests.isolate by completing chrome.isolate. Complete chrome.isolate to work on all platforms by extracting relevant data from browser_tests.isolate. Then make browser_tests.isolate 'includes' chrome.isolate and remove the duplicate entries. The story for bundling lib32 and lib64 NaCl libraries will have to cleared up since it depends on the OS running the test and on the build itself. Note: interactive_ui_tests.isolate doesn't actually start the chrome executable so it is not bundled. R=csharp@chromium.org NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242152

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -36 lines) Patch
M chrome/browser_tests.isolate View 5 chunks +3 lines, -35 lines 0 comments Download
M chrome/chrome.isolate View 3 chunks +14 lines, -1 line 1 comment Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
+ clusterfuzz folks fyi This CL is possible because of https://codereview.appspot.com/41950044, which was rolled in ...
7 years ago (2013-12-20 16:07:32 UTC) #1
csharp
lgtm
7 years ago (2013-12-20 17:49:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/106823003/1
7 years ago (2013-12-20 19:51:45 UTC) #3
commit-bot: I haz the power
Change committed as 242152
7 years ago (2013-12-20 19:56:04 UTC) #4
Ken Russell (switch to Gerrit)
7 years ago (2013-12-21 01:54:00 UTC) #5
Message was sent while issue was closed.
Thanks for this! It'll make adding the Telemetry isolates a lot easier.

Powered by Google App Engine
This is Rietveld 408576698